D10757: Reset QLocale internals when we have a custom app language

This revision was automatically updated to reflect the committed changes. Closed by commit R263:8361ddef0867: Reset QLocale internals when we have a custom app language (authored by aacid). REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10757?vs=28076=28132

D10757: Reset QLocale internals when we have a custom app language

apol added a comment. Go for it +1 I'd still try to add the needed API in Qt though. REPOSITORY R263 KXmlGui BRANCH master REVISION DETAIL https://phabricator.kde.org/D10757 To: aacid, apol, ilic Cc: lueck, #frameworks, michaelh

D10757: Reset QLocale internals when we have a custom app language

aacid updated this revision to Diff 28076. aacid added a comment. Now includes an auto test. It's not amazing since it doesn't totally reproduce the real world scenario but should be close enough. Had to make two functions be exported but since the header is not installed and it's

D10757: Reset QLocale internals when we have a custom app language

lueck added a comment. In D10757#212405 , @aacid wrote: > @lueck can you try this new version *without* https://phabricator.kde.org/D10758 and https://phabricator.kde.org/D10759 ? This should be enough to get QLocale to update itself.

D10757: Reset QLocale internals when we have a custom app language

aacid added inline comments. INLINE COMMENTS > apol wrote in kswitchlanguagedialog_p.cpp:94 > Not saying this is good or bad but clearly looks like Qt is missing some API > there. I don't know, the problem as far as i see it is that we're trying to do this in a generic way, a regular app

D10757: Reset QLocale internals when we have a custom app language

apol added inline comments. INLINE COMMENTS > kswitchlanguagedialog_p.cpp:94 > +// this is highly dependant on Qt internals, so may break, but oh > well > +QSystemLocale *dummy = new QSystemLocale(); > +delete dummy; Not saying this is good or bad but clearly looks like

D10757: Reset QLocale internals when we have a custom app language

aacid added a subscriber: lueck. aacid added a comment. @lueck can you try this new version *without* https://phabricator.kde.org/D10758 and https://phabricator.kde.org/D10759 ? This should be enough to get QLocale to update itself. REPOSITORY R263 KXmlGui BRANCH master REVISION

D10757: Reset QLocale internals when we have a custom app language

aacid updated this revision to Diff 27886. aacid retitled this revision from "Set QLocale too when we have a custom app language" to "Reset QLocale internals when we have a custom app language". aacid removed a subscriber: apol. aacid added a comment. Use QSystemLocale trick to reset QLocale