D10776: Make it possible to generate po files in parallel

2018-03-09 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes. Closed by commit R249:5a70e96795f1: Make it possible to generate po files in parallel (authored by apol). REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10776?vs=29024=29113 REVISION

D10776: Make it possible to generate po files in parallel

2018-03-09 Thread Harald Sitter
sitter accepted this revision. This revision is now accepted and ready to land. REPOSITORY R249 KI18n BRANCH master REVISION DETAIL https://phabricator.kde.org/D10776 To: apol, #frameworks, sitter Cc: michaelh

D10776: Make it possible to generate po files in parallel

2018-03-08 Thread Aleix Pol Gonzalez
apol marked an inline comment as done. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D10776 To: apol, #frameworks, sitter Cc: michaelh

D10776: Make it possible to generate po files in parallel

2018-03-08 Thread Aleix Pol Gonzalez
apol updated this revision to Diff 29024. apol added a comment. Fix typo REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10776?vs=28846=29024 BRANCH master REVISION DETAIL https://phabricator.kde.org/D10776 AFFECTED FILES cmake/build-pofiles.cmake

D10776: Make it possible to generate po files in parallel

2018-03-07 Thread Harald Sitter
sitter added inline comments. INLINE COMMENTS > build-tsfiles.cmake:75 > ${pmapc_file} > RESULT_VARIABLE code > ) This doesn't belong here, does it? It's also defined in execute_process() and from looking at the docs it would only be set once. REPOSITORY R249

D10776: Make it possible to generate po files in parallel

2018-03-06 Thread Aleix Pol Gonzalez
apol updated this revision to Diff 28846. apol added a comment. EQUAL REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10776?vs=28845=28846 BRANCH master REVISION DETAIL https://phabricator.kde.org/D10776 AFFECTED FILES cmake/build-pofiles.cmake

D10776: Make it possible to generate po files in parallel

2018-03-06 Thread Aleix Pol Gonzalez
apol updated this revision to Diff 28845. apol marked 3 inline comments as done. apol added a comment. Remove debug info and spaces REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10776?vs=28724=28845 BRANCH master REVISION DETAIL

D10776: Make it possible to generate po files in parallel

2018-03-05 Thread Harald Sitter
sitter added a comment. Ingenious code! You left some debug clutter behind though. Also, the if i statement is inconsistent between the two files `if (i EQUAL ${numberOfProcesses})` vs. `if (i GREATER ${numberOfProcesses})` INLINE COMMENTS > build-pofiles.cmake:45 > +

D10776: Make it possible to generate po files in parallel

2018-03-05 Thread Aleix Pol Gonzalez
apol updated this revision to Diff 28724. apol added a comment. Make sure we don't run more than nproc processes at the same time REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10776?vs=27871=28724 BRANCH master REVISION DETAIL

D10776: Make it possible to generate po files in parallel

2018-03-05 Thread Harald Sitter
sitter added a comment. As discussed on telegram: the proposed change makes it a different problem. Now instead of running serial all the time, it'd fork bomb all the time (peaks at 3671 forks for plasma-desktop 5.12 when run on a fairly fast system with SSD). Also, missing adjustment

D10776: Make it possible to generate po files in parallel

2018-02-23 Thread Aleix Pol Gonzalez
apol created this revision. apol added reviewers: Frameworks, sitter. Restricted Application added a project: Frameworks. apol requested review of this revision. REVISION SUMMARY Instead of going file by file, feed them to cmake at once. Should improve build times on some systems. TEST PLAN