This revision was automatically updated to reflect the committed changes.
Closed by commit R241:d38b373c8b76: Store temporary authorization status in
IdleSlave (authored by chinmoyr).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10822?vs=28581=31254
REVISION
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.
Thanks (I just realized we need a similar comment next to the enum value
MSG_SLAVE_STATUS though)
REPOSITORY
R241 KIO
BRANCH
D10822
REVISION DETAIL
chinmoyr updated this revision to Diff 28581.
chinmoyr added a comment.
added the required comment
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10822?vs=28577=28581
BRANCH
D10822
REVISION DETAIL
https://phabricator.kde.org/D10822
AFFECTED FILES
dfaure added a comment.
Thanks. Can you just add one comment, for the future?
INLINE COMMENTS
> idleslave.cpp:91
> +}
> +} else {
> +if (!stream.atEnd()) {
// compat code for KF < 5.45. TODO KF6: remove
REPOSITORY
R241 KIO
REVISION DETAIL
chinmoyr updated this revision to Diff 28577.
chinmoyr added a comment.
Added support for MSG_SLAVE_STATUS
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10822?vs=28543=28577
BRANCH
D10822
REVISION DETAIL
https://phabricator.kde.org/D10822
AFFECTED
dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> idleslave.cpp:70
> deleteLater();
> -} else if (cmd != MSG_SLAVE_STATUS) {
> +} else if (cmd != MSG_SLAVE_STATUS_V2) {
> qCritical()
chinmoyr updated this revision to Diff 28543.
chinmoyr added a comment.
Used MSG_SLAVE_STATUS_V2
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10822?vs=27998=28543
BRANCH
D10822
REVISION DETAIL
https://phabricator.kde.org/D10822
AFFECTED FILES
chinmoyr edited the summary of this revision.
chinmoyr added a dependency: D10820: Send slave's polkit authorization status
to the host.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D10822
To: chinmoyr, dfaure
Cc: #frameworks, michaelh, kmorwinski
chinmoyr added a dependent revision: D10824: Delete IdleSlave having temporary
authorization.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D10822
To: chinmoyr, dfaure
Cc: #frameworks, michaelh, kmorwinski
chinmoyr created this revision.
chinmoyr added a reviewer: dfaure.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
chinmoyr requested review of this revision.
REVISION SUMMARY
It will be used by klauncher to decide whether or not to
10 matches
Mail list logo
