This revision was automatically updated to reflect the committed changes.
Closed by commit R266:106b27347125: Remove frame around media action icons
(authored by romangg).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D11049?vs=28689=28898#toc
REPOSITORY
R266 Breeze Icons
CHANGES
ngraham accepted this revision.
ngraham added a comment.
Looks good to me too!
REPOSITORY
R266 Breeze Icons
BRANCH
reworkMediaActions
REVISION DETAIL
https://phabricator.kde.org/D11049
To: romangg, #breeze, #vdg, andreask, ngraham
Cc: ngraham, mart, #frameworks, michaelh
andreask accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R266 Breeze Icons
BRANCH
reworkMediaActions
REVISION DETAIL
https://phabricator.kde.org/D11049
To: romangg, #breeze, #vdg, andreask
Cc: mart, #frameworks, michaelh
romangg added a dependent revision: D11054: Add media status icons.
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D11049
To: romangg, #breeze, #vdg
Cc: mart, #frameworks, michaelh
mart added a comment.
as a pure code review, +1 from me as i see
style="fill:currentColor;fill-opacity:1;stroke:none" remained inalterated so
you did fix the mess inkscape likes to do with it :)
as style, i definitely like it more without circles around, final approval is
by Andreas.
romangg added a dependent revision: D11050: Remove frames around media buttons.
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D11049
To: romangg, #breeze, #vdg
Cc: #frameworks, michaelh
romangg added reviewers: Breeze, VDG.
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D11049
To: romangg, #breeze, #vdg
Cc: #frameworks, michaelh
romangg created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
romangg requested review of this revision.
REVISION SUMMARY
We were inconsistent on that and it can get in way with placement on buttons.
Also Research
