This revision was automatically updated to reflect the committed changes.
Closed by commit R290:8c7f78206b95: Mark kpackage_install_package undeprecated
for plasma_install_package (authored by kossebau).
REPOSITORY
R290 KPackage
CHANGES SINCE LAST UPDATE
mart accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R290 KPackage
BRANCH
allowdeprecatedwarningdisabling
REVISION DETAIL
https://phabricator.kde.org/D11129
To: kossebau, mart, apol
Cc: #frameworks, michaelh
kossebau added inline comments.
INLINE COMMENTS
> apol wrote in KF5PackageMacros.cmake:27
> How about if(KF5Plasma_FIND_VERSION VERSION_LESS 5.43.0)?
>
> This way it's only shown on projects that are actually depending on the new
> version. And if they are well then that's fine to have the
apol added inline comments.
INLINE COMMENTS
> KF5PackageMacros.cmake:27
> + # allow plasma_install_package to disable the warning until it is ported
> away from this
> + if (NOT ARGV4 STREQUAL NO_DEPRECATED_WARNING)
> + message(AUTHOR_WARNING "Deprecated: use
>
kossebau added a dependent revision: D11130: Disable deprecation warning from
kpackage_install_package for now.
REPOSITORY
R290 KPackage
REVISION DETAIL
https://phabricator.kde.org/D11129
To: kossebau, mart, apol
Cc: #frameworks, michaelh
kossebau created this revision.
kossebau added reviewers: mart, apol.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
kossebau requested review of this revision.
REVISION SUMMARY
While no-one is working on porting plasma_install_package
