D11132: Avoid an asan runtime error

This revision was automatically updated to reflect the committed changes. Closed by commit R302:af5397635c4f: Avoid an asan runtime error (authored by jtamate). REPOSITORY R302 KIconThemes CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11132?vs=29002=29026 REVISION DETAIL

D11132: Avoid an asan runtime error

mwolff added a comment. still accepted, fell free to submit REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D11132 To: jtamate, #frameworks, mwolff Cc: mwolff, apol, anthonyfieroni, michaelh

D11132: Avoid an asan runtime error

jtamate updated this revision to Diff 29002. jtamate added a comment. Added the link. REPOSITORY R302 KIconThemes CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11132?vs=28991=29002 REVISION DETAIL https://phabricator.kde.org/D11132 AFFECTED FILES src/kiconeffect.cpp To:

D11132: Avoid an asan runtime error

mwolff accepted this revision. mwolff added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > kiconeffect.cpp:44 > +KIconEffectPrivate() > + : effect{{}} > + , value{{}} it may be a good idea to add a comment that links to

D11132: Avoid an asan runtime error

jtamate updated this revision to Diff 28991. jtamate added a comment. with spaces after : and , REPOSITORY R302 KIconThemes CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11132?vs=28946=28991 REVISION DETAIL https://phabricator.kde.org/D11132 AFFECTED FILES

D11132: Avoid an asan runtime error

jtamate added inline comments. INLINE COMMENTS > apol wrote in kiconeffect.cpp:44 > To what does this initialize the array? effect: 0 value: 0 color: QColor(Invalid) trans: false key: "" color2: QColor(Invalid) REPOSITORY R302 KIconThemes REVISION DETAIL

D11132: Avoid an asan runtime error

apol added inline comments. INLINE COMMENTS > kiconeffect.cpp:44 > +KIconEffectPrivate(): > +effect{{}} > + ,value{{}} To what does this initialize the array? REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D11132 To: jtamate, #frameworks Cc:

D11132: Avoid an asan runtime error

jtamate updated this revision to Diff 28946. jtamate added a comment. Cleaner initialization, thanks anthonyfieroni. REPOSITORY R302 KIconThemes CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11132?vs=28943=28946 REVISION DETAIL https://phabricator.kde.org/D11132 AFFECTED

D11132: Avoid an asan runtime error

anthonyfieroni added inline comments. INLINE COMMENTS > kiconeffect.cpp:44-49 > +effect{{0}} > + ,value{{0.0}} > + ,color{{QColor()}} > + ,trans{{false}} > + ,key{{QString()}} > + ,color2{{QColor()}} You can use {{}} to all REPOSITORY R302 KIconThemes

D11132: Avoid an asan runtime error

jtamate created this revision. jtamate added a reviewer: Frameworks. Restricted Application added a project: Frameworks. jtamate requested review of this revision. REVISION SUMMARY Initialize the arrays to the maximum size of the enums and use c++11 initialization to ensure that all values are