D11323: [UDevManager] Also explicitly query for cameras

2018-03-15 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R245:9a54ef65305f: [UDevManager] Also explicitly query for cameras (authored by broulik). REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11323?vs=29489=29583 REVISION

D11323: [UDevManager] Also explicitly query for cameras

2018-03-15 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D11323 To: broulik, #frameworks, davidedmundson Cc: michaelh, ngraham

D11323: [UDevManager] Also explicitly query for cameras

2018-03-15 Thread Kai Uwe Broulik
broulik added a comment. > didn't we establish that devicesByProperty didn't work? It didn't work for media players where we query for `QVariant()` which turns into `nullptr` since there is no documentation on what that actually does (remove filter or check for property existance).

D11323: [UDevManager] Also explicitly query for cameras

2018-03-14 Thread David Edmundson
davidedmundson added a comment. didn't we establish that devicesByProperty didn't work? REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D11323 To: broulik, #frameworks, davidedmundson Cc: michaelh, ngraham

D11323: [UDevManager] Also explicitly query for cameras

2018-03-14 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Frameworks, davidedmundson. Restricted Application added a project: Frameworks. broulik requested review of this revision. REVISION SUMMARY Only camers with ID_GPHOTO2=1 are considered by the backend so we might as well just query for