D11470: SQL: various improvements and fix if/case/loop/end detection with SQL (Oracle)

This revision was automatically updated to reflect the committed changes. Closed by commit R216:3ebb3c09e512: SQL: various improvements and fix if/case/loop/end detection with SQL (Oracle) (authored by jpoelen). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D11470?vs=32861=40010#toc

D11470: SQL: various improvements and fix if/case/loop/end detection with SQL (Oracle)

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. I guess ok - if issues arise, we have to fix them :-) REPOSITORY R216 Syntax Highlighting BRANCH sql2 REVISION DETAIL https://phabricator.kde.org/D11470 To: jpoelen,

D11470: SQL: various improvements and fix if/case/loop/end detection with SQL (Oracle)

jpoelen added a comment. There have been changes in the xml files that will cause conflicts. I would look in the next few days. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D11470 To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc:

D11470: SQL: various improvements and fix if/case/loop/end detection with SQL (Oracle)

cullmann accepted this revision. cullmann added a comment. Restricted Application added a project: Kate. Restricted Application edited subscribers, added: kde-frameworks-devel, kwrite-devel; removed: Frameworks. Beside the short arc confusion, the current state can go in, or? REPOSITORY

D11470: SQL: various improvements and fix if/case/loop/end detection with SQL (Oracle)

jpoelen added a comment. The page on Phabricator is much better than before. My problem was about creating a branch without the `-t` option which requires me to specify a commit/branch to do the diff. I also realized later that I was reloading a page from the revision history, so I

D11470: SQL: various improvements and fix if/case/loop/end detection with SQL (Oracle)

rkflx added a comment. Sorry for chiming in, but in light of the focus goal T7116: Streamlined onboarding of new contributors it's important to fix rough edges in our infrastructure, too: In D11470#252163 ,

D11470: SQL: various improvements and fix if/case/loop/end detection with SQL (Oracle)

jpoelen updated this revision to Diff 32861. jpoelen added a comment. I am completely lost with `arc diff`. The command adds files that I did not normally modify in this branch and specifiying a reference commit does not seem to work. I ended up doing everything through a new branch,

D11470: SQL: various improvements and fix if/case/loop/end detection with SQL (Oracle)

jpoelen updated this revision to Diff 32860. jpoelen added a comment. - SQL: various improvements and fix if/case/loop/end detection with SQL (Oracle) - add sql tests - update kateversion to 5.0 and allows multiple spaces for "end if", "end case" and "end loop" -

D11470: SQL: various improvements and fix if/case/loop/end detection with SQL (Oracle)

jpoelen updated this revision to Diff 32855. jpoelen added a comment. - diff with the proper branch CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11470?vs=32853=32855 BRANCH new_sql_oracle REVISION DETAIL https://phabricator.kde.org/D11470 AFFECTED FILES

D11470: SQL: various improvements and fix if/case/loop/end detection with SQL (Oracle)

jpoelen updated this revision to Diff 32853. jpoelen added a comment. - autotests/input/highlight.sh.syntax and autotests/input/highlight.sh are restored REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11470?vs=32852=32853 BRANCH

D11470: SQL: various improvements and fix if/case/loop/end detection with SQL (Oracle)

jpoelen updated this revision to Diff 32852. jpoelen added a comment. - SQL: various improvements and fix if/case/loop/end detection with SQL (Oracle) - add sql tests - update kateversion to 5.0 and allows multiple spaces for "end if", "end case" and "end loop" REPOSITORY R216 Syntax

D11470: SQL: various improvements and fix if/case/loop/end detection with SQL (Oracle)

dhaumann requested changes to this revision. dhaumann added a comment. This revision now requires changes to proceed. Looks mostly good, but there are some minor issues we first need to address: - dsControlFlow and similar default styles were added with KDE Frameworks 5, so

D11470: SQL: various improvements and fix if/case/loop/end detection with SQL (Oracle)

jpoelen added a comment. There is a bug on which I fell while completing the tests: the output is not stable. Several successive calls to `./bin/kate-syntax-highlighter $PROJ/autotests/input/test.sql` give a different result. `valgrind` returns a lot of "Conditional jump or move

D11470: SQL: various improvements and fix if/case/loop/end detection with SQL (Oracle)

jpoelen updated this revision to Diff 29866. jpoelen added a comment. File mode restored for autotests/input/highlight.sh and autotests/input/highlight.sh.syntax REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11470?vs=29865=29866 BRANCH sql

D11470: SQL: various improvements and fix if/case/loop/end detection with SQL (Oracle)

jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann. Restricted Application added a project: Frameworks. jpoelen requested review of this revision. REVISION SUMMARY Previously, the variables prefixed by if / case / loop / end are a mix of keywords