D11685: Implement single click on line number to select line of text

dhaumann added a comment. Ok, thanks! REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D11685 To: rkron, #frameworks, #kate, #ktexteditor, ngraham, cullmann Cc: kwrite-devel, kde-frameworks-devel, dhaumann, rkron, mwolff, ngraham, #ktexteditor, #kate, #frameworks,

D11685: Implement single click on line number to select line of text

rkron added a comment. Yes, tested and it works. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D11685 To: rkron, #frameworks, #kate, #ktexteditor, ngraham, cullmann Cc: kwrite-devel, kde-frameworks-devel, dhaumann, rkron, mwolff, ngraham, #ktexteditor, #kate,

D11685: Implement single click on line number to select line of text

dhaumann added a comment. Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. Btw, did anyone test with dynamic word wrap enabled? Does it still work, when a line spans multiple view lines? REPOSITORY R39 KTextEditor REVISION DETAIL

D11685: Implement single click on line number to select line of text

ngraham closed this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D11685 To: rkron, #frameworks, #kate, #ktexteditor, ngraham, cullmann Cc: dhaumann, rkron, mwolff, ngraham, #ktexteditor, #kate, #frameworks, michaelh, kevinapavew, bruns, demsking,

D11685: Implement single click on line number to select line of text

rkron added a comment. Would someone please land this for me? Thanks. REPOSITORY R39 KTextEditor BRANCH Bug372503 (branched from master) REVISION DETAIL https://phabricator.kde.org/D11685 To: rkron, #frameworks, #kate, #ktexteditor, ngraham, cullmann Cc: dhaumann, rkron, mwolff,

D11685: Implement single click on line number to select line of text

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. I have no strong opinions on that, as I am not really using the line numbers in such a way. But I think it can't hurt to have this in. REPOSITORY R39 KTextEditor BRANCH

D11685: Implement single click on line number to select line of text

ngraham added a comment. Where are we with this patch? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D11685 To: rkron, #frameworks, #kate, #ktexteditor, ngraham, cullmann Cc: dhaumann, rkron, mwolff, ngraham, #ktexteditor, #kate, #frameworks, michaelh,

D11685: Implement single click on line number to select line of text

ngraham added a subscriber: dhaumann. ngraham added a comment. @cullmann @dhaumann ping? I'm quite fond of this, myself. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D11685 To: rkron, #frameworks, #kate, #ktexteditor, ngraham, cullmann Cc: dhaumann, rkron,

D11685: Implement single click on line number to select line of text

rkron marked 4 inline comments as done. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D11685 To: rkron, #frameworks, #kate, #ktexteditor, ngraham, cullmann Cc: rkron, mwolff, richardbowen, ngraham, #ktexteditor, #kate, #frameworks, michaelh, kevinapavew, bruns,

D11685: Implement single click on line number to select line of text

rkron edited the summary of this revision. rkron edited the test plan for this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D11685 To: rkron, #frameworks, #kate, #ktexteditor, ngraham, cullmann Cc: mwolff, richardbowen, ngraham, #ktexteditor, #kate,

D11685: Implement single click on line number to select line of text

rkron updated this revision to Diff 31505. rkron added a comment. - Revise patch per review comments. Added comments and removed code to fix view scrolling inconsistancy when dragging over line numbers. REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

D11685: Implement single click on line number to select line of text

mwolff added a comment. the "also" in your commit message: can you split this commit into two parts, or is the feature addition also fixing the bug? Put differently: Could you first fix the bug, then add the feature, in separate commits? INLINE COMMENTS > kateviewhelpers.cpp:2018 >

D11685: Implement single click on line number to select line of text

rkron updated this revision to Diff 31182. rkron added a comment. - Removed two unnecessary lines in patch. REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11685?vs=30560=31182 BRANCH Bug372503 (branched from master) REVISION DETAIL

D11685: Implement single click on line number to select line of text

ngraham added a comment. +1 behaviorally! REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D11685 To: rkron, #frameworks, #kate, #ktexteditor, ngraham, cullmann Cc: richardbowen, ngraham, #ktexteditor, #kate, #frameworks, michaelh, kevinapavew, demsking, cullmann,

D11685: Implement single click on line number to select line of text

rkron added a reviewer: cullmann. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D11685 To: rkron, #frameworks, #kate, #ktexteditor, ngraham, cullmann Cc: richardbowen, ngraham, #ktexteditor, #kate, #frameworks, michaelh, kevinapavew, demsking, cullmann, sars,

D11685: Implement single click on line number to select line of text

rkron edited the summary of this revision. rkron edited the test plan for this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D11685 To: rkron, #frameworks, #kate, #ktexteditor, ngraham Cc: richardbowen, ngraham, #ktexteditor, #kate, #frameworks, michaelh,

D11685: Implement single click on line number to select line of text

rkron updated this revision to Diff 30560. rkron added a comment. - Update revision per review comments. Removed the config option to enable and disable the single-click behavior. REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11685?vs=30517=30560

D11685: Implement single click on line number to select line of text

rkron added a comment. @ngraham Qt Designer made those changes when I added the checkbox. They will be gone with the update. The four files concerning the config option will be as they were before this revision. REPOSITORY R39 KTextEditor REVISION DETAIL

D11685: Implement single click on line number to select line of text

ngraham added a comment. @richardbowen, this isn't a support forum, it's for patch review. Please only leave comments related to the patch itself. Thanks! REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D11685 To: rkron, #frameworks, #kate, #ktexteditor, ngraham

D11685: Implement single click on line number to select line of text

ngraham added inline comments. INLINE COMMENTS > navigationconfigwidget.ui:43 > > - Autocenter cursor: > + Autocenter cursor: > Unrelated change? > navigationconfigwidget.ui:92 > > - Text selection mode: > + Text

D11685: Implement single click on line number to select line of text

richardbowen added a comment. In D11685#234040 , @rkron wrote: > And actually, if you have the line modification marker border turned on, clicking in it will just move the cursor without selecting the line. Not sure what the line

D11685: Implement single click on line number to select line of text

rkron added a comment. And actually, if you have the line modification marker border turned on, clicking in it will just move the cursor without selecting the line. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D11685 To: rkron, #frameworks, #kate,

D11685: Implement single click on line number to select line of text

richardbowen added a comment. With the double click option, it allows for two different functionality (place at home row, and highlight) as opposed to one if there was only 1 click to highlight. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D11685 To: rkron,

D11685: Implement single click on line number to select line of text

rkron added a comment. @ngraham I agree. Single-click is pretty much standard. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D11685 To: rkron, #frameworks, #kate, #ktexteditor, ngraham Cc: richardbowen, ngraham, #ktexteditor, #kate, #frameworks, michaelh,

D11685: Implement single click on line number to select line of text

ngraham added a comment. In D11685#234009 , @richardbowen wrote: > How about double click to highlight instead of tripple click? I think consistency with the common interaction method is important here: other text editors implement this

D11685: Implement single click on line number to select line of text

richardbowen added a comment. How about double click to highlight instead of tripple click? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D11685 To: rkron, #frameworks, #kate, #ktexteditor, ngraham Cc: richardbowen, ngraham, #ktexteditor, #kate, #frameworks,

D11685: Implement single click on line number to select line of text

rkron added a comment. OK. I will remove the option and update the revision. Thanks for the input! REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D11685 To: rkron, #frameworks, #kate, #ktexteditor, ngraham Cc: ngraham, #ktexteditor, #kate, #frameworks, michaelh,

D11685: Implement single click on line number to select line of text

ngraham added a comment. IMHO, a mouse-based workflow for selecting large blocks of text makes sense, which is why this should be made at least the default setting. But using the mouse to go to the first column makes less sense, since you're probably about to do something with the text,

D11685: Implement single click on line number to select line of text

rkron added a comment. If you think it should be on by default, that's easily done. I know what you mean, that nobody would ever find it. When I first started using Kate, I thought the triple-clicking was very annoying. But I got used to it and now it's automatic for me. It also became

D11685: Implement single click on line number to select line of text

ngraham added a comment. Gave it a whirl; this is very nice! I don't think making it optional and off by default is the best choice, though. Nobody will ever find it. I would support making this enabled by default at the very least, and possibly even not turn-off-able with an option.

D11685: Implement single click on line number to select line of text

rkron edited the test plan for this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D11685 To: rkron, #frameworks, #kate, #ktexteditor, ngraham Cc: ngraham, #ktexteditor, #kate, #frameworks, michaelh, kevinapavew, demsking, cullmann, sars, dhaumann

D11685: Implement single click on line number to select line of text

rkron created this revision. rkron added reviewers: Frameworks, Kate, KTextEditor, ngraham. Restricted Application added projects: Kate, Frameworks. rkron requested review of this revision. REVISION SUMMARY Implements selecting entire line of text with a single click on line number.