D11705: Highlight selected items when showing parent folder from the open/save dialog

This revision was automatically updated to reflect the committed changes. Closed by commit R241:05fe10da0034: Highlight selected items when showing parent folder from the open/save dialog (authored by ngraham). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D11705: Highlight selected items when showing parent folder from the open/save dialog

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH arcpatch-D11705 REVISION DETAIL https://phabricator.kde.org/D11705 To: ngraham, #frameworks, broulik Cc: broulik, michaelh, ngraham

D11705: Highlight selected items when showing parent folder from the open/save dialog

ngraham added a comment. Also, we have a request to add an Open action to the menu (https://bugs.kde.org/show_bug.cgi?id=392329), which would take care of the use case of wanting to directly open the folder. I plan to submit a patch for that, too. REPOSITORY R241 KIO REVISION DETAIL

D11705: Highlight selected items when showing parent folder from the open/save dialog

ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11705 To: ngraham, #frameworks Cc: broulik, michaelh, ngraham

D11705: Highlight selected items when showing parent folder from the open/save dialog

ngraham marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11705 To: ngraham, #frameworks Cc: broulik, michaelh, ngraham

D11705: Highlight selected items when showing parent folder from the open/save dialog

ngraham added a comment. In D11705#234324 , @broulik wrote: > Good idea. > > How about folders? Perhaps we should use a different behavior for folders as you're imho more likely to want to open a folder in the file manager than look "where

D11705: Highlight selected items when showing parent folder from the open/save dialog

ngraham updated this revision to Diff 30622. ngraham added a comment. Fix the case where nothing is selected (i.e. when the user right-clicks on the background) REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11705?vs=30582=30622 BRANCH arcpatch-D11705

D11705: Highlight selected items when showing parent folder from the open/save dialog

broulik added a comment. Good idea. How about folders? Perhaps we should use a different behavior for folders as you're imho more likely to want to open a folder in the file manager than look "where it is" INLINE COMMENTS > kdiroperator.cpp:666 > { > -new KRun(currUrl, parent); >

D11705: Highlight selected items when showing parent folder from the open/save dialog

ngraham created this revision. ngraham added a reviewer: Frameworks. Restricted Application added a project: Frameworks. ngraham requested review of this revision. REVISION SUMMARY For the open/save dialogs' Open File Manager context menu item, this patch adopts `KIO::highlightInFileManager()`