bruns added a comment.
Herald added a subscriber: kde-frameworks-devel.
Ping!
REPOSITORY
R245 Solid
REVISION DETAIL
https://phabricator.kde.org/D12125
To: bruns, #frameworks
Cc: kde-frameworks-devel, broulik, #frameworks, michaelh, ngraham, bruns
bruns marked an inline comment as done.
REPOSITORY
R245 Solid
REVISION DETAIL
https://phabricator.kde.org/D12125
To: bruns, #frameworks
Cc: broulik, #frameworks, michaelh, bruns
bruns added a reviewer: Frameworks.
REPOSITORY
R245 Solid
REVISION DETAIL
https://phabricator.kde.org/D12125
To: bruns, #frameworks
Cc: broulik, #frameworks, michaelh, ngraham, bruns
bruns added inline comments.
INLINE COMMENTS
> broulik wrote in udisksdevicebackend.cpp:147
> So when size is unknown it will always query it as you will never have a Size
> in the `m_propertyCache`?
It uses the one from the Partition or Block Interface, see last paragraph from
the Summary.
broulik added inline comments.
INLINE COMMENTS
> udisksdevicebackend.cpp:147
> +if (size.isValid() && size.toInt() != 0) {
> +m_propertyCache.insert(QStringLiteral("Size"), size);
> +}
So when size is unknown it will always query it as you
bruns added a dependency: D12124: Avoid creating duplicate property entries in
the cache.
REPOSITORY
R245 Solid
REVISION DETAIL
https://phabricator.kde.org/D12125
To: bruns
Cc: #frameworks, michaelh, ngraham, bruns
bruns created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
bruns requested review of this revision.
REVISION SUMMARY
UDisks2 added a "Size" property for the Filesystem interface, which may
be zero, denoting an
