D12197: autotests: Test for multiple values

bruns requested changes to this revision. bruns added a comment. This revision now requires changes to proceed. This depends on the pending discussion how "Subject" and "Keyword" should be handled, see D10694 REPOSITORY R286 KFileMetaData REVISION

D12197: autotests: Test for multiple values

ngraham added a comment. Restricted Application added a subscriber: kde-frameworks-devel. @michaelh Ping! Can we land this? REPOSITORY R286 KFileMetaData BRANCH multi-value-test (branched from master) REVISION DETAIL https://phabricator.kde.org/D12197 To: michaelh, #baloo,

D12197: autotests: Test for multiple values

mgallien accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH multi-value-test (branched from master) REVISION DETAIL https://phabricator.kde.org/D12197 To: michaelh, #baloo, #frameworks, mgallien, bruns Cc: bruns, ashaposhnikov,

D12197: autotests: Test for multiple values

michaelh requested review of this revision. michaelh marked an inline comment as done. michaelh added inline comments. INLINE COMMENTS > bruns wrote in multivaluetest.cpp:91 > Again, I prefer this notation versus `expectedresult` > You can make this somewhat shorter by using >

D12197: autotests: Test for multiple values

michaelh added a reviewer: bruns. REPOSITORY R286 KFileMetaData BRANCH multi-value-test (branched from master) REVISION DETAIL https://phabricator.kde.org/D12197 To: michaelh, #baloo, #frameworks, mgallien, bruns Cc: bruns, ashaposhnikov, michaelh, astippich, spoorun

D12197: autotests: Test for multiple values

michaelh updated this revision to Diff 32559. michaelh added a comment. - Rebase - Apply some suggested changes REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12197?vs=32122=32559 BRANCH multi-value-test (branched from master) REVISION DETAIL

D12197: autotests: Test for multiple values

bruns added inline comments. INLINE COMMENTS > multivaluetest.cpp:90 > +<< QStringLiteral("application/epub+zip") > +<< Property::Subject > +<< QVariantList{QVariant(QStringLiteral("Baloo KFileMetaData"))} Here you use the property value directly, while in other places

D12197: autotests: Test for multiple values

mgallien accepted this revision. mgallien added a comment. This revision is now accepted and ready to land. Sorry, that was a local problem. REPOSITORY R286 KFileMetaData BRANCH multi-value-test REVISION DETAIL https://phabricator.kde.org/D12197 To: michaelh, #baloo, #frameworks,

D12197: autotests: Test for multiple values

mgallien requested changes to this revision. mgallien added a comment. This revision now requires changes to proceed. The test for mp3 is failing to complete. I am investigating. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D12197 To: michaelh, #baloo,

D12197: autotests: Test for multiple values

mgallien accepted this revision. mgallien added a comment. This revision is now accepted and ready to land. Thanks REPOSITORY R286 KFileMetaData BRANCH multi-value-test REVISION DETAIL https://phabricator.kde.org/D12197 To: michaelh, #baloo, #frameworks, mgallien Cc: bruns,

D12197: autotests: Test for multiple values

michaelh edited the summary of this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D12197 To: michaelh, #baloo, #frameworks, mgallien Cc: bruns, ashaposhnikov, michaelh, astippich, spoorun, ngraham, alexeymin

D12197: autotests: Test for multiple values

bruns added a comment. "Prepare sample files for tags which may have multiple values" REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D12197 To: michaelh, #baloo, #frameworks, mgallien Cc: bruns, ashaposhnikov, michaelh, astippich, spoorun, ngraham, alexeymin

D12197: autotests: Test for multiple values

michaelh added a dependent revision: D10694: epubextractor: Handle multiple subjects better. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D12197 To: michaelh, #baloo, #frameworks, mgallien Cc: ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns,

D12197: autotests: Test for multiple values

michaelh added inline comments. INLINE COMMENTS > multivaluetest.cpp:86 > + > +// Provide Property::Subject only when there is exactly one dc:subject > +QTest::newRow("epub/1 subject") The following behaviours need to be discussed. They are just suggestions. REPOSITORY R286

D12197: autotests: Test for multiple values

michaelh created this revision. michaelh added reviewers: Baloo, Frameworks, mgallien. Restricted Application added projects: Frameworks, Baloo. michaelh requested review of this revision. REVISION SUMMARY Prepare sample files with multiple tags - epub: 'dc:subject' - office docs: