D12420: Make the warning text for deletion operations emphasize its permanency and irreversibility

ngraham closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12420 To: ngraham, #frameworks, #dolphin, elvisangelaccio Cc: broulik, michaelh, ngraham, bruns

D12420: Make the warning text for deletion operations emphasize its permanency and irreversibility

ngraham added a comment. 5.46 has been tagged; landing this today. REPOSITORY R241 KIO BRANCH more-serious-delete-text (branched from master) REVISION DETAIL https://phabricator.kde.org/D12420 To: ngraham, #frameworks, #dolphin, elvisangelaccio Cc: broulik, michaelh, ngraham, bruns

D12420: Make the warning text for deletion operations emphasize its permanency and irreversibility

ngraham added a comment. Thanks, will push after tagging next week. REPOSITORY R241 KIO BRANCH more-serious-delete-text (branched from master) REVISION DETAIL https://phabricator.kde.org/D12420 To: ngraham, #frameworks, #dolphin, elvisangelaccio Cc: broulik, michaelh, bruns

D12420: Make the warning text for deletion operations emphasize its permanency and irreversibility

elvisangelaccio accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH more-serious-delete-text (branched from master) REVISION DETAIL https://phabricator.kde.org/D12420 To: ngraham, #frameworks, #dolphin, elvisangelaccio Cc: broulik,

D12420: Make the warning text for deletion operations emphasize its permanency and irreversibility

ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12420 To: ngraham, #frameworks, #dolphin, elvisangelaccio Cc: broulik, michaelh, bruns

D12420: Make the warning text for deletion operations emphasize its permanency and irreversibility

ngraham updated this revision to Diff 33310. ngraham added a comment. Add extra linebreak and fix a tag REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12420?vs=33074=33310 BRANCH more-serious-delete-text (branched from master) REVISION DETAIL

D12420: Make the warning text for deletion operations emphasize its permanency and irreversibility

ngraham marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12420 To: ngraham, #frameworks, #dolphin, elvisangelaccio Cc: broulik, michaelh, bruns

D12420: Make the warning text for deletion operations emphasize its permanency and irreversibility

elvisangelaccio added a comment. I liked more the version with two newlines before the bold sentence, is there a reason why you changed to only one? INLINE COMMENTS > jobuidelegate.cpp:239 > widget, > - i18nc("@info", "Do you want to

D12420: Make the warning text for deletion operations emphasize its permanency and irreversibility

ngraham added a comment. Thanks Kai! I'll wait until after tagging to land it, assuming @elvisangelaccio is satisfied by that point. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12420 To: ngraham, #frameworks, #dolphin, elvisangelaccio Cc: broulik, michaelh, bruns

D12420: Make the warning text for deletion operations emphasize its permanency and irreversibility

broulik added a comment. Looking at it again, I think you convinved me. Just mind the string freeze (two weeks before tag), push it only after the upcoming Frameworks tag. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12420 To: ngraham, #frameworks, #dolphin,

D12420: Make the warning text for deletion operations emphasize its permanency and irreversibility

broulik added a comment. How about adding "Permanently" to the action button? And no I don't want to turn off confirmation for deleting files. > makes the similarly destructive delete action say the same thing. I see. It's not bold, though. REPOSITORY R241 KIO REVISION

D12420: Make the warning text for deletion operations emphasize its permanency and irreversibility

ngraham added a comment. Besides, people like you (and me) who find this kind of hand-holding annoying can (and likely do) just check the checkbox for "Do not ask again". Problem solved. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12420 To: ngraham, #frameworks,

D12420: Make the warning text for deletion operations emphasize its permanency and irreversibility

ngraham added a comment. 1. We already have the sentence "This action cannot be undone" in the empty trash dialog alongside the word "permanently". This patch just makes the similarly destructive delete action say the same thing. 2. It's well known the users barely read this kind of

D12420: Make the warning text for deletion operations emphasize its permanency and irreversibility

broulik added a comment. -1 What about "permanently" do you not understand. Also -1000 for bold text. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12420 To: ngraham, #frameworks, #dolphin, elvisangelaccio Cc: broulik, michaelh, bruns

D12420: Make the warning text for deletion operations emphasize its permanency and irreversibility

ngraham marked 2 inline comments as done. ngraham added a comment. Thanks for your patience, Elvis. Your experience and guidance is much appreciated. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12420 To: ngraham, #frameworks, #dolphin, elvisangelaccio Cc: michaelh,

D12420: Make the warning text for deletion operations emphasize its permanency and irreversibility

ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12420 To: ngraham, #frameworks, #dolphin, elvisangelaccio Cc: michaelh, bruns

D12420: Make the warning text for deletion operations emphasize its permanency and irreversibility

ngraham updated this revision to Diff 33074. ngraham marked an inline comment as done. ngraham added a comment. Do this correctly REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12420?vs=32885=33074 BRANCH more-serious-delete-text (branched from master)

D12420: Make the warning text for deletion operations emphasize its permanency and irreversibility

elvisangelaccio requested changes to this revision. elvisangelaccio added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > ngraham wrote in jobuidelegate.cpp:229 > Couldn't get `` working, so I hope `` tags are okay. Nope, see the following warnings: "Tag 'p'

D12420: Make the warning text for deletion operations emphasize its permanency and irreversibility

ngraham marked an inline comment as done. ngraham added inline comments. INLINE COMMENTS > elvisangelaccio wrote in jobuidelegate.cpp:229 > Please use semantic markup and the `` tag instead of `\n`, see > https://api.kde.org/frameworks/ki18n/html/prg_guide.html#kuit_markup Couldn't get ``

D12420: Make the warning text for deletion operations emphasize its permanency and irreversibility

ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12420 To: ngraham, #frameworks, #dolphin, elvisangelaccio Cc: michaelh, bruns

D12420: Make the warning text for deletion operations emphasize its permanency and irreversibility

ngraham updated this revision to Diff 32885. ngraham added a comment. Use semantic markup tags REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12420?vs=32748=32885 BRANCH more-serious-delete-text (branched from master) REVISION DETAIL

D12420: Make the warning text for deletion operations emphasize its permanency and irreversibility

elvisangelaccio added inline comments. INLINE COMMENTS > jobuidelegate.cpp:229 > widget, > - i18np("Do you really want to delete this item?", > "Do you really want to delete these %1 items?", prettyList.count()), > +

D12420: Make the warning text for deletion operations emphasize its permanency and irreversibility

ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12420 To: ngraham, #frameworks, #dolphin, elvisangelaccio Cc: michaelh, bruns

D12420: Make the warning text for deletion operations emphasize its permanency and irreversibility

ngraham updated this revision to Diff 32748. ngraham added a comment. Move the warnings to their own line so they're not missed, and also to improve the presentation REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12420?vs=32732=32748 BRANCH

D12420: Make the warning text for deletion operations emphasize its permanency and irreversibility

ngraham added a dependent revision: D12422: Use a regular dialog rather than a list dialog when trashing or deleting a single file. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12420 To: ngraham, #frameworks, #dolphin, elvisangelaccio Cc: michaelh, bruns

D12420: Make the warning text for deletion operations emphasize its permanency and irreversibility

ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12420 To: ngraham, #frameworks, #dolphin, elvisangelaccio Cc: michaelh, bruns

D12420: Make the warning text for deletion operations emphasize its permanency and irreversibility

ngraham created this revision. ngraham added reviewers: Frameworks, Dolphin, elvisangelaccio. Restricted Application added a project: Frameworks. ngraham requested review of this revision. TEST PLAN [image goes here] REPOSITORY R241 KIO BRANCH more-serious-delete-text (branched from