D12538: Allow accepting by double-click in save dialog

This revision was automatically updated to reflect the committed changes. Closed by commit R241:c537a717363c: Allow accepting by double-click in save dialog (authored by anemeth). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12538?vs=33914=33930 REVISION

D12538: Allow accepting by double-click in save dialog

rkflx accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH arcpatch-D12538 (branched from master) REVISION DETAIL https://phabricator.kde.org/D12538 To: anemeth, #frameworks, #vdg, ngraham, rkflx Cc: kde-frameworks-devel, ltoscano, rkflx,

D12538: Allow accepting by double-click in save dialog

ngraham accepted this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12538 To: anemeth, #frameworks, #vdg, ngraham, rkflx Cc: kde-frameworks-devel, ltoscano, rkflx, broulik, jtamate, ngraham, #frameworks, michaelh, bruns

D12538: Allow accepting by double-click in save dialog

ngraham added inline comments. INLINE COMMENTS > anemeth wrote in kfilewidget.cpp:1866 > I'm having a lot of trouble finding the correct syntax... > And the compiler is giving me 100 lines of cryptic error message. > Could you help me out on this one? Hmm, you're right, I can't get it to work

D12538: Allow accepting by double-click in save dialog

anemeth marked 2 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12538 To: anemeth, #frameworks, #vdg, ngraham, rkflx Cc: kde-frameworks-devel, ltoscano, rkflx, broulik, jtamate, ngraham, #frameworks, michaelh, bruns

D12538: Allow accepting by double-click in save dialog

anemeth updated this revision to Diff 33914. anemeth added a comment. - Remove QFileInfo REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12538?vs=33900=33914 BRANCH arcpatch-D12538 (branched from master) REVISION DETAIL https://phabricator.kde.org/D12538

D12538: Allow accepting by double-click in save dialog

anemeth added inline comments. INLINE COMMENTS > rkflx wrote in kfilewidget.cpp:1866 > Well, how should that line look like then? I'm having a lot of trouble finding the correct syntax... And the compiler is giving me 100 lines of cryptic error message. Could you help me out on this one?

D12538: Allow accepting by double-click in save dialog

rkflx added inline comments. INLINE COMMENTS > ngraham wrote in kfilewidget.cpp:1866 > Not for everything, just this one. Well, how should that line look like then? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12538 To: anemeth, #frameworks, #vdg, ngraham, rkflx Cc:

D12538: Allow accepting by double-click in save dialog

ngraham added inline comments. INLINE COMMENTS > rkflx wrote in kfilewidget.cpp:1866 > Is this even possible without a lot of refactoring (which would be > out-of-scope for this patch)? Not for everything, just this one. REPOSITORY R241 KIO REVISION DETAIL

D12538: Allow accepting by double-click in save dialog

rkflx added inline comments. INLINE COMMENTS > ngraham wrote in kfilewidget.cpp:1866 > Let's use new-style signal/slot syntax for new code. See > https://wiki.qt.io/New_Signal_Slot_Syntax Is this even possible without a lot of refactoring (which would be out-of-scope for this patch)? >

D12538: Allow accepting by double-click in save dialog

ngraham added a comment. Nice! Behaviorally, this works well now and I didn't find any regressions. Just some code style comments below: INLINE COMMENTS > kfilewidget.cpp:1189 > } > + > } Unnecessary unrelated whitespace change > kfilewidget.cpp:1866 > + > +

D12538: Allow accepting by double-click in save dialog

anemeth updated this revision to Diff 33900. anemeth added a comment. Restricted Application added a subscriber: kde-frameworks-devel. - Merge branch 'master' of git://anongit.kde.org/kio into arcpatch-D12538 - Double clicking to save only works on files REPOSITORY R241 KIO CHANGES SINCE

D12538: Allow accepting by double-click in save dialog

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. For me this also breaks entering folders with double-click even before I cancel the first overwrite: it immediately closes the dialog and saves in the current directory.

D12538: Allow accepting by double-click in save dialog

rkflx added a comment. In D12538#255954 , @anemeth wrote: > In D12538#254871 , @rkflx wrote: > > > However, for double click mode and Save, descending into directories is kinda broken. You might

D12538: Allow accepting by double-click in save dialog

rkflx retitled this revision from "Always prompt for overwrite on double-click in save dialog" to "Allow accepting by double-click in save dialog". rkflx edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12538 To: anemeth, #frameworks,