D12578: fix some issues reported by clazy

This revision was automatically updated to reflect the committed changes. Closed by commit R293:f887468b172a: fix some issues reported by clazy (authored by mgallien). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12578?vs=34389=34390 REVISION DETAIL

D12578: fix some issues reported by clazy

bruns accepted this revision. bruns added a comment. This revision is now accepted and ready to land. No, worries, just wanted to make shure this does not stall 1 meter to the finish line ... REPOSITORY R293 Baloo BRANCH arcpatch-D12578 REVISION DETAIL

D12578: fix some issues reported by clazy

mgallien marked an inline comment as done. mgallien added a comment. @bruns Thanks for the review and sorry for my slowness. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12578 To: mgallien, #baloo, #frameworks, bruns Cc: kde-frameworks-devel, bruns, ashaposhnikov,

D12578: fix some issues reported by clazy

mgallien updated this revision to Diff 34389. mgallien added a comment. - fix one more issue REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12578?vs=34223=34389 BRANCH arcpatch-D12578 REVISION DETAIL https://phabricator.kde.org/D12578 AFFECTED FILES

D12578: fix some issues reported by clazy

bruns requested changes to this revision. bruns added a comment. This revision now requires changes to proceed. One change pending, then you are good to go ... REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12578 To: mgallien, #baloo, #frameworks, bruns Cc:

D12578: fix some issues reported by clazy

bruns added inline comments. INLINE COMMENTS > searchstore.cpp:163 > if (term.operation() == Term::And || term.operation() == Term::Or) { > QList subTerms = term.subTerms(); > QVector vec; `const QList subterms = ...` REPOSITORY R293 Baloo REVISION

D12578: fix some issues reported by clazy

mgallien updated this revision to Diff 34223. mgallien added a comment. fix some issues REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12578?vs=33247=34223 BRANCH arcpatch-D12578 REVISION DETAIL https://phabricator.kde.org/D12578 AFFECTED FILES

D12578: fix some issues reported by clazy

mgallien added a comment. In D12578#262831 , @bruns wrote: > @mgallien - I think this is trivial to fix up - can you do, so we have one less request open? I will do but as I had started working on that as a low priority task, I have not

D12578: fix some issues reported by clazy

bruns added a comment. Restricted Application added a subscriber: kde-frameworks-devel. @mgallien - I think this is trivial to fix up - can you do, so we have one less request open? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12578 To: mgallien, #baloo,

D12578: fix some issues reported by clazy

bruns requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12578 To: mgallien, #baloo, #frameworks, bruns Cc: bruns, ashaposhnikov, michaelh, astippich, spoorun

D12578: fix some issues reported by clazy

bruns added inline comments. INLINE COMMENTS > CMakeLists.txt:4 > set(REQUIRED_QT_VERSION 5.8.0) > -set(KF5_VERSION "5.45.0") # handled by release scripts > -set(KF5_DEP_VERSION "5.45.0") # handled by release scripts > +set(KF5_VERSION "5.44.0") # handled by release scripts >

D12578: fix some issues reported by clazy

mgallien created this revision. mgallien added reviewers: Baloo, Frameworks. Restricted Application added projects: Frameworks, Baloo. mgallien requested review of this revision. REVISION SUMMARY fix some issues reported by clazy TEST PLAN tests are OK REPOSITORY R293 Baloo BRANCH