D12662: Add InlineNoteInterface

cullmann commandeered this revision. cullmann added a reviewer: michalsrb. cullmann added a comment. Hi, we will process further things of this request in Sven's copy D14826 : inline note interface wip #2. REPOSITORY R39 KTextEditor REVISION DETAIL

D12662: Add InlineNoteInterface

cullmann abandoned this revision. cullmann added a comment. Head over to D14826 : inline note interface wip #2. for the current state. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D12662 To: cullmann, #ktexteditor, michalsrb

D12662: Add InlineNoteInterface

michalsrb added a comment. In D12662#307752 , @brauch wrote: > I'd like to play with this a bit wrt what can be done in KDevelop with it (I want the problem popups gone). Would you mind if I do some changes along the way? I would post an

D12662: Add InlineNoteInterface

brauch added a comment. I'd like to play with this a bit wrt what can be done in KDevelop with it (I want the problem popups gone). Would you mind if I do some changes along the way? I would post an updated patch here, in case I actually come up with useful changes ... REPOSITORY R39

D12662: Add InlineNoteInterface

brauch added a comment. By the way, other people around here are very impressed by this patch as well, and we'd really like to get this merged :) Moving e.g. KDevelop's warning markers into an inline note instead of the annoying popup would make a real difference for usability ...

D12662: Add InlineNoteInterface

brauch added a comment. Wow, that looks amazing! Really impressive. Using moving cursors for this sounds good to me. Other things which cannot be updated in real-time do that as well (highlighting, error underlines, ...) Regarding the cursor issue: I think you would need a state

D12662: Add InlineNoteInterface

michalsrb added a comment. Sorry, I had almost no time to work on it. I got stuck trying to figure out how to properly handle the notes at the beginning of the lines. Then I created KDevelop plugin as experiment to try if the interface is usable:

D12662: Add InlineNoteInterface

brauch added a comment. Restricted Application edited subscribers, added: kde-frameworks-devel, kwrite-devel; removed: Frameworks. Hey there, what's happening to this? I think this is a really nice feature and it would be very sad if it would bitrot :( Anything anyone can assist with? We

D12662: Add InlineNoteInterface

brauch added inline comments. INLINE COMMENTS > dhaumann wrote in katedocument.cpp:5316-5320 > Btw, may I am wrong here, since this is really called often when painting > lines... So this may be good to have. I also stumbled upon it but it avoids an alloc in a very deep loop, so it might be

D12662: Add InlineNoteInterface

dhaumann added inline comments. INLINE COMMENTS > dhaumann wrote in katedocument.cpp:5316-5320 > This look like premature optimization. I would prefer to delete this "common > cases first" block. Except if this turned out to be a bottleneck already? Btw, may I am wrong here, since this is

D12662: Add InlineNoteInterface

dhaumann added a comment. This is already an excellent patch. The API documentation is already really nice. I have some minor suggestions (see inline comments in patch). Besides that, I wonder whether this should really be a View extension interaface. Currently, this interface is

D12662: Add InlineNoteInterface

brauch added a comment. Oh, heh, yes it does. It's just your docstring which says otherwise ("is an interface for the View"), and that's what I looked at at that time. That should be changed. ;) I think the question is less what you need and more what it is supposed to do semantically.

D12662: Add InlineNoteInterface

cullmann added a comment. > Oh, good point by the way: Are you sure this should be an interface to a *view*? Maybe it should instead be attached to the document? I'm not sure, I just want to bring the discussion up. Actually, I think view might make sense, as you only mess with the

D12662: Add InlineNoteInterface

brauch added a comment. I think fixing the selection rendering issue would be nice. Regarding blockmode behaviour, I think it will be a bit strange either way. One thing to compare is the behaviour with non-fixed width fonts: there block mode also selects constant columns (i.e. it will

D12662: Add InlineNoteInterface

michalsrb added a comment. In D12662#257342 , @brauch wrote: > Looks good from the implementation too so far. One thing I do not see is any changes to the cursorToX / xToCursor functions, is there really no change required there? No

D12662: Add InlineNoteInterface

brauch added a comment. Looks good from the implementation too so far. One thing I do not see is any changes to the cursorToX / xToCursor functions, is there really no change required there? Some things which come to my mind for testing would be: - is selection rendered correctly

D12662: Add InlineNoteInterface

michalsrb added a comment. Here are screenshots from the sample plugin: F5831086: txt.png F5831085: cpp.png F5831084: qml.png The plugin provides notes that are just

D12662: Add InlineNoteInterface

brauch added a comment. Awesome idea! Do you have a screenshot of how it looks? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D12662 To: michalsrb, #ktexteditor Cc: brauch, #frameworks, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars, dhaumann

D12662: Add InlineNoteInterface

michalsrb added a comment. This is my first attempt to propose such API, it may not be ideal. If the inline note is placed into text, the space for it is created using QTextCharFormat's absolute spacing between the two letters. I admit it is quite a misuse, but it was the least

D12662: Add InlineNoteInterface

michalsrb added a reviewer: KTextEditor. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D12662 To: michalsrb, #ktexteditor Cc: #frameworks, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars, dhaumann

D12662: Add InlineNoteInterface

michalsrb created this revision. Restricted Application added projects: Kate, Frameworks. Restricted Application added a subscriber: Frameworks. michalsrb requested review of this revision. REVISION SUMMARY The inline note interface provides a way to render arbitrary things in the text. The