D12744: Add null pointer check when creating SocketAddress

This revision was automatically updated to reflect the committed changes. Closed by commit R241:bf7bfe9353c5: Add null pointer check when creating SocketAddress (authored by chinmoyr). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12744?vs=34961&id=35323 REVISIO

D12744: Add null pointer check when creating SocketAddress

ossi accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D12744 To: chinmoyr, dfaure, ossi Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12744: Add null pointer check when creating SocketAddress

chinmoyr updated this revision to Diff 34961. chinmoyr marked 2 inline comments as done. chinmoyr added a comment. fixed the issues mentioned REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12744?vs=33831&id=34961 BRANCH master REVISION DETAIL https://phab

D12744: Add null pointer check when creating SocketAddress

ossi requested changes to this revision. ossi added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > fdreceiver.cpp:34 > { > +const SocketAddress addr(m_path.toLocal8Bit().constData()); > +if (!addr.address()) { it would be more elegant to use m_path.toL

D12744: Add null pointer check when creating SocketAddress

dfaure accepted this revision. This revision is now accepted and ready to land. Restricted Application edited subscribers, added: kde-frameworks-devel; removed: Frameworks. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D12744 To: chinmoyr, dfaure, ossi Cc:

D12744: Add null pointer check when creating SocketAddress

chinmoyr updated this revision to Diff 33831. chinmoyr added a comment. Used qPrintable() REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12744?vs=33820&id=33831 BRANCH master REVISION DETAIL https://phabricator.kde.org/D12744 AFFECTED FILES src/ioslave

D12744: Add null pointer check when creating SocketAddress

dfaure added inline comments. INLINE COMMENTS > dfaure wrote in fdreceiver.cpp:36 > print out `m_path.toLocal8Bit()` here? Possibly nitpicking, but toStdString converts to utf8 while toLocal8Bit() is what's used for SocketAddress and what's recommended for terminal output as well. If toLocal8B

D12744: Add null pointer check when creating SocketAddress

chinmoyr updated this revision to Diff 33820. chinmoyr added a comment. Print the invalid socket path in case of an error. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12744?vs=33769&id=33820 BRANCH master REVISION DETAIL https://phabricator.kde.org/D12

D12744: Add null pointer check when creating SocketAddress

dfaure added inline comments. INLINE COMMENTS > fdreceiver.cpp:36 > +if (!addr.address()) { > +std::cerr << "Invalid socket address" << std::endl; > +return; print out `m_path.toLocal8Bit()` here? > fdsender.cpp:31 > +if (!addr.address()) { > +std::cerr << "Inval

D12744: Add null pointer check when creating SocketAddress

chinmoyr added a dependent revision: D12745: Unify API for file descriptor sharing. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12744 To: chinmoyr, dfaure, ossi Cc: #frameworks, michaelh, ngraham, bruns

D12744: Add null pointer check when creating SocketAddress

chinmoyr added a dependency: D10411: Create socket file in user's runtime directory. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12744 To: chinmoyr, dfaure, ossi Cc: #frameworks, michaelh, ngraham, bruns

D12744: Add null pointer check when creating SocketAddress

chinmoyr created this revision. chinmoyr added reviewers: dfaure, ossi. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. chinmoyr requested review of this revision. REVISION SUMMARY If for some reason SocketAddress:make_address() fails to