This revision was automatically updated to reflect the committed changes.
heikobecker marked an inline comment as done.
Closed by commit R249:918e304f057b: KF5I18NMacros: Don't install an empty
dir when no po files exist (authored by heikobecker).
REPOSITORY
R249 KI18n
CHANGES SINCE LAST UPDAT
ltoscano accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R249 KI18n
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D12905
To: heikobecker, ilic, ltoscano
Cc: apol, ltoscano, kde-frameworks-devel, michaelh, ngraham, bruns
heikobecker marked an inline comment as done.
heikobecker added a comment.
Considering the feedback I'll probably merge this in a few days if no
objections turn up in the meantime.
INLINE COMMENTS
> ltoscano wrote in KF5I18NMacros.cmake.in:138-139
> I guess that those two lines are the criti
apol added a comment.
LGTM
REPOSITORY
R249 KI18n
REVISION DETAIL
https://phabricator.kde.org/D12905
To: heikobecker, ilic
Cc: apol, ltoscano, kde-frameworks-devel, michaelh, ngraham, bruns
ltoscano added a comment.
Looks fine by me, let's see if there are other comments.
INLINE COMMENTS
> KF5I18NMacros.cmake.in:138-139
>
> -file(MAKE_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/${dirname})
> -install(DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/${dirname} DESTINATION
> ${destname}
ltoscano added a reviewer: ilic.
REPOSITORY
R249 KI18n
REVISION DETAIL
https://phabricator.kde.org/D12905
To: heikobecker, ilic
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
heikobecker created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
heikobecker requested review of this revision.
REVISION SUMMARY
I saw this happen with kdecoration from git since
64d9f92f6a8708814f414dda0bb0
