D12945: kcoredirlister lstItems benchmark

2018-07-27 Thread Jaime Torres Amate
This revision was automatically updated to reflect the committed changes. Closed by commit R241:908bfca9fe72: kcoredirlister lstItems benchmark (authored by jtamate). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D12945?vs=38134=38612#toc REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D12945: kcoredirlister lstItems benchmark

2018-07-27 Thread Jaime Torres Amate
jtamate edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12945 To: jtamate, dfaure, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12945: kcoredirlister lstItems benchmark

2018-07-26 Thread David Faure
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12945 To: jtamate, dfaure, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12945: kcoredirlister lstItems benchmark

2018-07-20 Thread Jaime Torres Amate
jtamate updated this revision to Diff 38134. jtamate marked 6 inline comments as done. jtamate edited the summary of this revision. jtamate added a comment. Hopefully done all the requested changes. Passed uncristify-kf5. Removed the classes for simulating the filtering. Added

D12945: kcoredirlister lstItems benchmark

2018-07-06 Thread David Faure
dfaure added a comment. It's also interesting to look at numbers for small directories (which is still the most common case, too). This code could use a run of uncrustify to match the coding style of the rest of kio, but otherwise it looks good. INLINE COMMENTS >

D12945: kcoredirlister lstItems benchmark

2018-06-05 Thread Jaime Torres Amate
jtamate updated this revision to Diff 35585. jtamate edited the summary of this revision. jtamate added a comment. Changed the structure QListBinaryHash to QMap Changed from KFileItems pointers to Values (it caused memory problems). Imported the parts that handle the filters to do the

D12945: kcoredirlister lstItems benchmark

2018-05-30 Thread Jaime Torres Amate
jtamate added a dependency: D13211: Enable comparing KFileItems by url. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12945 To: jtamate, dfaure, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12945: kcoredirlister lstItems benchmark

2018-05-25 Thread David Faure
dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kcoredirlister_benchmark.cpp:244 > +uint hash=qHash(url); > +auto it = std::lower_bound(lstItems.cbegin(), lstItems.cend(), hash, >

D12945: kcoredirlister lstItems benchmark

2018-05-17 Thread Jaime Torres Amate
jtamate added a dependent revision: D11282: less expensive findByUrl in KCoreDirListerCache. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12945 To: jtamate, dfaure, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12945: kcoredirlister lstItems benchmark

2018-05-17 Thread Jaime Torres Amate
jtamate created this revision. jtamate added reviewers: dfaure, Frameworks. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. jtamate requested review of this revision. REVISION SUMMARY Decide which data structure is best for