D13302: check for needed version of libavcode, libavformat and libavutil

2018-06-07 Thread Matthieu Gallien
This revision was automatically updated to reflect the committed changes. Closed by commit R286:461f8ec81b81: check for needed version of libavcode, libavformat and libavutil (authored by mgallien). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE

D13302: check for needed version of libavcode, libavformat and libavutil

2018-06-07 Thread Jonathan Riddell
jriddell accepted this revision. jriddell added a comment. This revision is now accepted and ready to land. latest patch works well in neon REPOSITORY R286 KFileMetaData BRANCH master REVISION DETAIL https://phabricator.kde.org/D13302 To: mgallien, romangg, adridg, jriddell Cc:

D13302: check for needed version of libavcode, libavformat and libavutil

2018-06-06 Thread Matthieu Gallien
mgallien updated this revision to Diff 35712. mgallien added a comment. - checks if FFmpeg provides the new API and use it only in this case extend the existing configure header to allow to compile both versions of the code in the FFmpeg extractor in case the new API exists, we

D13302: check for needed version of libavcode, libavformat and libavutil

2018-06-03 Thread Roman Gilg
romangg added a comment. I tried this patch on Neon with FFmpeg 2.8.14. KFileMetaData builds now because it detects that the FFmpeg module version numbers are too low. CMake log: P230 Few remarks: - In the log it says 3 times `Could NOT

D13302: check for needed version of libavcode, libavformat and libavutil

2018-06-03 Thread Matthieu Gallien
mgallien updated this revision to Diff 35457. mgallien added a comment. - prefer usage of CHECK_STRUCT_HAS_MEMBER instead of having test code the test is shorter with CHECK_STRUCT_HAS_MEMBER (thanks @adridg for the help) REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE

D13302: check for needed version of libavcode, libavformat and libavutil

2018-06-03 Thread Matthieu Gallien
mgallien retitled this revision from "[WIP] check for needed version of libavcode, libavformat and libavutil" to "check for needed version of libavcode, libavformat and libavutil". mgallien edited the test plan for this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL