D13316: manually set format in jpeg thumbnail creator

This revision was automatically updated to reflect the committed changes. Closed by commit R320:880a09adae2a: manually set format in jpeg thumbnail creator (authored by miklosm, committed by ngraham). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE

D13316: manually set format in jpeg thumbnail creator

elvisangelaccio accepted this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D13316 To: miklosm, dfaure, elvisangelaccio, #frameworks Cc: kde-frameworks-devel, kfm-devel, ngraham, alexde, feverfew, michaelh, spoorun, navarromorales, firef, andrebarros,

D13316: manually set format in jpeg thumbnail creator

ngraham added a comment. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. Is there any reason not to commit this now? REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D13316 To: miklosm, dfaure, elvisangelaccio,

D13316: manually set format in jpeg thumbnail creator

miklosm added a comment. In D13316#327854 , @ngraham wrote: > @miklosm, can this go in now, or it is dependent on either of your other two patches? All three patches need to be in place to fix bug 220496. The thumbnail creators need

D13316: manually set format in jpeg thumbnail creator

ngraham added a comment. @miklosm, can this go in now, or it is dependent on either of your other two patches? REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D13316 To: miklosm, dfaure, elvisangelaccio, #frameworks Cc: ngraham

D13316: manually set format in jpeg thumbnail creator

ngraham edited the summary of this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D13316 To: miklosm, dfaure, elvisangelaccio, #frameworks Cc: ngraham

D13316: manually set format in jpeg thumbnail creator

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D13316 To: miklosm, dfaure, elvisangelaccio, #frameworks Cc: ngraham

D13316: manually set format in jpeg thumbnail creator

miklosm added a comment. In D13316#288653 , @elvisangelaccio wrote: > I guess this change makes sense (given that we are in the jpeg plugin), but what about `QImageReader::decideFormatFromContent()` ? The file type was already detected

D13316: manually set format in jpeg thumbnail creator

elvisangelaccio added a comment. I guess this change makes sense (given that we are in the jpeg plugin), but what about `QImageReader::decideFormatFromContent()` ? REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D13316 To: miklosm, dfaure, elvisangelaccio,

D13316: manually set format in jpeg thumbnail creator

ngraham added reviewers: dfaure, elvisangelaccio, Frameworks. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D13316 To: miklosm, dfaure, elvisangelaccio, #frameworks