This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R127:c981d5406f80: OutputManagement fractional scaling
(authored by davidedmundson).
CHANGED PRIOR TO COMMIT
davidedmundson updated this revision to Diff 37097.
davidedmundson added a comment.
Rebase
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D13601?vs=36919=37097
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D13601
AFFECTED FILES
davidedmundson updated this revision to Diff 36919.
davidedmundson added a comment.
Also emit scale changed when scaleF changes
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D13601?vs=36910=36919
REVISION DETAIL
https://phabricator.kde.org/D13601
davidedmundson updated this revision to Diff 36910.
davidedmundson added a comment.
Rebase
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D13601?vs=36908=36910
REVISION DETAIL
https://phabricator.kde.org/D13601
AFFECTED FILES
davidedmundson updated this revision to Diff 36908.
davidedmundson added a comment.
qFuzzyCompare
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D13601?vs=36907=36908
REVISION DETAIL
https://phabricator.kde.org/D13601
AFFECTED FILES
davidedmundson updated this revision to Diff 36907.
davidedmundson marked 2 inline comments as done.
davidedmundson added a comment.
qFuzzyCompare
(not sure it's relevant as the comparison it makes is greater than
the resolution of wl_fixed, but whatever)
REPOSITORY
R127 KWayland
romangg requested changes to this revision.
This revision now requires changes to proceed.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D13601
To: davidedmundson, #kwin, romangg
Cc: romangg, zzag, kde-frameworks-devel, michaelh, ngraham, bruns
romangg added inline comments.
INLINE COMMENTS
> outputdevice_interface.cpp:449
> SETTER(setScale, int, scale)
> +SETTER(setScaleF, qreal, scale)
> SETTER(setSubPixel, SubPixel, subPixel)
The macro does not do a fuzzy compare.
> outputdevice_interface.h:138
> void
davidedmundson updated this revision to Diff 36518.
davidedmundson added a comment.
whitespace changes
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D13601?vs=36330=36518
BRANCH
davidedmundson/scalef
REVISION DETAIL
zzag added inline comments.
INLINE COMMENTS
> outputdevice.cpp:413
>
> +
> bool OutputDevice::isValid() const
Extra new line.
> outputconfiguration_interface.cpp:73
> +static void scaleFCallback(wl_client *client, wl_resource *resource,
> + wl_resource *
davidedmundson added a dependent revision: D13617: Support kwin fractional
scaling in wayland backend.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D13601
To: davidedmundson, #kwin
Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns
davidedmundson updated this revision to Diff 36330.
davidedmundson added a comment.
const
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D13601?vs=36318=36330
BRANCH
davidedmundson/scalef
REVISION DETAIL
https://phabricator.kde.org/D13601
AFFECTED
zzag added inline comments.
INLINE COMMENTS
> outputconfiguration_interface.cpp:194
> +Q_UNUSED(client);
> +qreal scale = wl_fixed_to_double(scale_fixed);
> +
Nitpick: can be const. :-)
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D13601
To:
davidedmundson created this revision.
davidedmundson added a reviewer: KWin.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.
REVISION SUMMARY
In order to have fractional
14 matches
Mail list logo
