D13743: Migrate build system to use find_package in autotests/ki18n_install

This revision was automatically updated to reflect the committed changes. Closed by commit R249:507415c54bd1: Migrate build system to use find_package in autotests/ki18n_install (authored by habacker). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D13743?vs=38569=39339#toc REPOSITORY

D13743: Migrate build system to use find_package in autotests/ki18n_install

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Ah, I see. This fails indeed: CMake Error at CMakeLists.txt:4 (include): include could not find load file: KF5I18nMacros REPOSITORY R249 KI18n BRANCH master

D13743: Migrate build system to use find_package in autotests/ki18n_install

habacker added a comment. In D13743#304127 , @dfaure wrote: > I don't understand either, what does this fix? The macro file is intended to be used by client packages and is normally fetched by KI18nConfig.cmake, which is provided with

D13743: Migrate build system to use find_package in autotests/ki18n_install

habacker added a comment. In D13743#298834 , @apol wrote: > Looks good to me, I don't really see why it's better though... This way you can find problems that are normally detected by client packages simply by running make test

D13743: Migrate build system to use find_package in autotests/ki18n_install

dfaure added a comment. I don't understand either, what does this fix? Is cmake run separately on autotests/ki18n_install/CMakeLists.txt? REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D13743 To: habacker, apol, ilic Cc: dfaure, bcooksley, ltoscano,

D13743: Migrate build system to use find_package in autotests/ki18n_install

habacker updated this revision to Diff 38569. habacker added a comment. - rebased REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13743?vs=36708=38569 BRANCH master REVISION DETAIL https://phabricator.kde.org/D13743 AFFECTED FILES CMakeLists.txt

D13743: Migrate build system to use find_package in autotests/ki18n_install

apol added a comment. Looks good to me, I don't really see why it's better though... Actually calling find_package on KF5I18n will define twice the targets such as KF5::I18n, I'm not sure this will even work alright. REPOSITORY R249 KI18n REVISION DETAIL

D13743: Migrate build system to use find_package in autotests/ki18n_install

habacker added a comment. ping REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D13743 To: habacker, apol, ilic Cc: bcooksley, ltoscano, kde-frameworks-devel, michaelh, ngraham, bruns

D13743: Migrate build system to use find_package in autotests/ki18n_install

bcooksley added a comment. Setting up automatic notifications requires permission to alter the global Herald rules, which only a member of #community_admins can do. Please ping one of them or file a #Sysadmin

D13743: Migrate build system to use find_package in autotests/ki18n_install

habacker added a comment. In D13743#283757 , @ltoscano wrote: > Most of the projects are configured so that the reviews are automatic subscription to the relevant list. This means that the people involved with the project should already know

D13743: Migrate build system to use find_package in autotests/ki18n_install

ltoscano added a comment. Most of the projects are configured so that the reviews are automatic subscription to the relevant list. This means that the people involved with the project should already know about it, even without a reviewer and despite the message from phabricator UI.

D13743: Migrate build system to use find_package in autotests/ki18n_install

habacker removed a reviewer: leinir. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D13743 To: habacker, apol, ilic, leinir Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13743: Migrate build system to use find_package in autotests/ki18n_install

habacker added a comment. Sorry, copy and paste bug It is complicate to find the correct reviewer for a project, because by default reviews do not get any reviewer by default. .arcconfig located in a related git repo clone does not contain any hint. REPOSITORY R249 KI18n REVISION

D13743: Migrate build system to use find_package in autotests/ki18n_install

ltoscano added reviewers: apol, ilic. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D13743 To: habacker, leinir, apol, ilic Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13743: Migrate build system to use find_package in autotests/ki18n_install

leinir added a comment. This seems quite sensible to me, a cleanup and simplification of the test build system is not bad... That said, i'm unsure why you think i'm qualified to speak about ki18n and the general cmake build system to a level high enough that you highlight me

D13743: Migrate build system to use find_package in autotests/ki18n_install

habacker created this revision. habacker added a reviewer: leinir. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. habacker requested review of this revision. REVISION SUMMARY The current build system used an incomplete