D13782: RFC: Ignore NTFS hidden flag for root volume

ngraham added a comment. @broulik? Is it ready to land? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13782 To: broulik, dfaure, yurikoles, bruns Cc: ngraham, oysteins, wbauer, kde-frameworks-devel, michaelh, bruns

D13782: RFC: Ignore NTFS hidden flag for root volume

oysteins added a comment. I cannot speak for the code, but this seems to work perfectly well when I tested it today. I used Kate and KBackup to open some files/directories on an external NTFS, and used KBackup to write a backup to the drive. I didn't have to check 'Show hidden folders' and

D13782: RFC: Ignore NTFS hidden flag for root volume

wbauer added a comment. In D13782#297639 , @wbauer wrote: > Using QDir::canonicalPath() (instead of QDir::cleanPath() ) would fix all 3 cases: > > const QString fullFilePath = QDir(path + QLatin1Char('/') + filename).canonicalPath(); >

D13782: RFC: Ignore NTFS hidden flag for root volume

wbauer added a comment. In D13782#297547 , @wbauer wrote: > With additional debug output I do see the '.' entry in the root dir still marked as hidden (as mentioned in the test plan), and also the '..' entry in (first-level) subdirs is hidden.

D13782: RFC: Ignore NTFS hidden flag for root volume

wbauer added a subscriber: ngraham. wbauer added a comment. In D13782#296381 , @ngraham wrote: > @wbauer, does this work for you now? Yes, it does work as expected now here in all cases I tested, and I didn't notice problems. With

D13782: RFC: Ignore NTFS hidden flag for root volume

ngraham resigned from this revision. ngraham added a comment. @wbauer, does this work for you now? Or @bruns? Still cannot test as I have no NTFS partitions. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13782 To: broulik, dfaure, yurikoles, bruns Cc: oysteins,

D13782: RFC: Ignore NTFS hidden flag for root volume

broulik added a comment. Ping REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13782 To: broulik, dfaure, ngraham, yurikoles, bruns Cc: oysteins, wbauer, kde-frameworks-devel, michaelh, ngraham, bruns

D13782: RFC: Ignore NTFS hidden flag for root volume

broulik updated this revision to Diff 37229. broulik added a comment. Also check for `DT_UNKNOWN` REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13782?vs=36838=37229 REVISION DETAIL https://phabricator.kde.org/D13782 AFFECTED FILES

D13782: RFC: Ignore NTFS hidden flag for root volume

jtamate added a dependent revision: D13915: Use non deprecated fastInsert in file_unix. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13782 To: broulik, dfaure, ngraham, yurikoles, bruns Cc: wbauer, kde-frameworks-devel, michaelh, ngraham, bruns

D13782: RFC: Ignore NTFS hidden flag for root volume

wbauer added inline comments. INLINE COMMENTS > file_unix.cpp:566 > +// Bug 392913: NTFS root volume is always "hidden", > ignore this > +if (ep->d_type == DT_DIR) { > +const QString fullFilePath = path + QLatin1Char('/') > +

D13782: RFC: Ignore NTFS hidden flag for root volume

wbauer added a comment. In D13782#287336 , @wbauer wrote: > I tried the patch and it doesn't make a difference here, the mountpoint of my NTFS partition is still hidden. > (it's on an internal drive and mounted to /windows/C via fstab in case

D13782: RFC: Ignore NTFS hidden flag for root volume

wbauer added a comment. I tried the patch and it doesn't make a difference here, the mountpoint of my NTFS partition is still hidden. (it's on an internal drive and mounted to /windows/C via fstab in case it matters) Additional debug output showed that ep->d_type is not DT_DIR but 0

D13782: RFC: Ignore NTFS hidden flag for root volume

broulik added a reviewer: bruns. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13782 To: broulik, dfaure, ngraham, yurikoles, bruns Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13782: RFC: Ignore NTFS hidden flag for root volume

broulik updated this revision to Diff 36838. broulik added a comment. Only check for folders, a file cannot be a mount, saves querying mount points for hidden files REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13782?vs=36837=36838 REVISION DETAIL

D13782: RFC: Ignore NTFS hidden flag for root volume

broulik created this revision. broulik added reviewers: dfaure, ngraham, yurikoles. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Those are always hidden as far as