D13804: [KRecentDocument] Consider duplicate entries only based on path, not launched app

elvisangelaccio added a comment. No need to apologize, that's what code reviews are for :) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13804 To: ngraham, broulik, #dolphin, #frameworks, cfeck Cc: elvisangelaccio, cfeck, kde-frameworks-devel, michaelh, ngraham, bruns

D13804: [KRecentDocument] Consider duplicate entries only based on path, not launched app

ngraham abandoned this revision. ngraham added a comment. Hmm, I can't reproduce it now either. I could have sworn that the issue reproduced for me when I originally tested the bug and submitted the patch, so maybe it was fixed by something else in the meantime. Or maybe I tested it wrong

D13804: [KRecentDocument] Consider duplicate entries only based on path, not launched app

elvisangelaccio added a comment. Same, there is only one entry there. Not sure what's going on, maybe somewhere else we are already filtering out duplicates? REPOSITORY R241 KIO BRANCH more-liberal-recent-document-duplicate-detection (branched from master) REVISION DETAIL

D13804: [KRecentDocument] Consider duplicate entries only based on path, not launched app

ngraham added a comment. In D13804#310036 , @elvisangelaccio wrote: > I cannot reproduce the linked bug. If open the same file in both kate and kwrite I get only one entry in krunner (despite the file having two different

D13804: [KRecentDocument] Consider duplicate entries only based on path, not launched app

elvisangelaccio added a comment. I cannot reproduce the linked bug. If open the same file in both kate and kwrite I get only one entry in krunner (despite the file having two different `X-KDE-LastOpenedWith` values in .`local/share/RecentDocuments/`). REPOSITORY R241 KIO BRANCH

D13804: [KRecentDocument] Consider duplicate entries only based on path, not launched app

ngraham updated this revision to Diff 39816. ngraham added a comment. Rebase on master REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13804?vs=36920=39816 BRANCH more-liberal-recent-document-duplicate-detection (branched from master) REVISION DETAIL

D13804: [KRecentDocument] Consider duplicate entries only based on path, not launched app

ngraham added a comment. Still works, and the same document is still available in the Open Recent... menu of multiple apps if you open it in multiple apps. Been using this for a month and a half. I'm hesitant to land it without more reviews, though. REPOSITORY R241 KIO BRANCH

D13804: [KRecentDocument] Consider duplicate entries only based on path, not launched app

ngraham added a comment. Thanks! BTW, It's now technically acceptable for the `BUG:` keyword to go at the beginning. Sysadmins fixed the bug that was preventing this from working before. @broulik does this patch make sense to you? For me it does not break the case of the same document

D13804: [KRecentDocument] Consider duplicate entries only based on path, not launched app

cfeck accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH more-liberal-recent-document-duplicate-detection (branched from master) REVISION DETAIL https://phabricator.kde.org/D13804 To: ngraham, broulik, #dolphin, #frameworks, cfeck Cc:

D13804: [KRecentDocument] Consider duplicate entries only based on path, not launched app

cfeck edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13804 To: ngraham, broulik, #dolphin, #frameworks Cc: cfeck, kde-frameworks-devel, michaelh, ngraham, bruns

D13804: [KRecentDocument] Consider duplicate entries only based on path, not launched app

ngraham added a comment. What you say theoretically makes sense, but try it out: the document appears in the Recent Documents menu for both Kate and KWrite, while multi-app aggregator UIs continue to not accumulate duplicates. REPOSITORY R241 KIO REVISION DETAIL

D13804: [KRecentDocument] Consider duplicate entries only based on path, not launched app

cfeck added a comment. But if I open the file in Kate, it appears in Kate's "Open Recent" menu, even if I previously had opened it in KWrite? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13804 To: ngraham, broulik, #dolphin, #frameworks Cc: cfeck,

D13804: [KRecentDocument] Consider duplicate entries only based on path, not launched app

ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13804 To: ngraham, broulik, #dolphin, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13804: [KRecentDocument] Consider duplicate entries only based on path, not launched app

ngraham created this revision. ngraham added reviewers: broulik, Dolphin, Frameworks. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY BUG: 379129 FIXED-IN 5.48