D13899: KMessageWidget: use theme instead of hardcoded colours

ngraham added a comment. I think the problem here is that while themes have dedicated Positive, Negative, and Neutral colors, for the Informational color we just re-use the active or highlight color from the theme, which may not always be appropriate for use as a background for

D13899: KMessageWidget: use theme instead of hardcoded colours

rjvbb added a comment. This is what approach 1 looks like with (clockwise) Breeze Dark, Oxygen and Wonton Soup: F6110913: image.png Positive messages don't have an icon here because currently only the Breeze icon set has a "positive" icon. The

D13899: KMessageWidget: use theme instead of hardcoded colours

ngraham added a comment. This patch works as advertised, and does not imposes any visual regressions when using the Breeze color scheme. And yet, when trying it out with non-default color schemes, I can't help but wonder what we're actually accomplishing here. While the Positive color

D13899: KMessageWidget: use theme instead of hardcoded colours

rjvbb marked 6 inline comments as done. rjvbb added a comment. Ping? REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D13899 To: rjvbb, #frameworks, #vdg Cc: aacid, broulik, kde-frameworks-devel, michaelh, crozbo, firef, ngraham, bruns, skadinna,

D13899: KMessageWidget: use theme instead of hardcoded colours

rjvbb set the repository for this revision to R236 KWidgetsAddons. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D13899 To: rjvbb, #frameworks, #vdg Cc: aacid, broulik, kde-frameworks-devel, michaelh, crozbo, firef, ngraham, bruns, skadinna, aaronhoneycutt,

D13899: KMessageWidget: use theme instead of hardcoded colours

rjvbb updated this revision to Diff 37194. rjvbb added a comment. constifies KThemeSettings. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13899?vs=37188=37194 REVISION DETAIL https://phabricator.kde.org/D13899 AFFECTED FILES src/CMakeLists.txt src/kmessagewidget.cpp

D13899: KMessageWidget: use theme instead of hardcoded colours

aacid added a comment. I know the class is not exported, but having it be "const correct" is always nice :) INLINE COMMENTS > kthemesettings_p.h:66 > + */ > +bool isValid(); > + const? > kthemesettings_p.h:71 > + */ > +bool contains(const QString ); > + const? >

D13899: KMessageWidget: use theme instead of hardcoded colours

rjvbb set the repository for this revision to R236 KWidgetsAddons. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D13899 To: rjvbb, #frameworks, #vdg Cc: broulik, kde-frameworks-devel, michaelh, crozbo, firef, ngraham, bruns, skadinna, aaronhoneycutt, mbohlender

D13899: KMessageWidget: use theme instead of hardcoded colours

rjvbb updated this revision to Diff 37188. rjvbb marked 3 inline comments as done. rjvbb edited the summary of this revision. rjvbb edited the test plan for this revision. rjvbb added a comment. Patch updated as requested. CHANGES SINCE LAST UPDATE

D13899: KMessageWidget: use theme instead of hardcoded colours

rjvbb marked 15 inline comments as done. rjvbb added inline comments. INLINE COMMENTS > broulik wrote in kthemesettings.cpp:30 > This doesn't cascade to system-wide settings I aligned to what KConfig actually does: it only considers the kdeglobals file in the writable generic config location.

D13899: KMessageWidget: use theme instead of hardcoded colours

broulik added a comment. I like the idea INLINE COMMENTS > kmessagewidget.cpp:172 > QColor bgBaseColor; > +const QPalette palette = QGuiApplication::palette(); > Not using the widget's palette was intentional for Konsole or something I recall? > kmessagewidget.cpp:176 > +//

D13899: KMessageWidget: use theme instead of hardcoded colours

rjvbb added a comment. A few snapshots obtained with runtime theme changes (see also D13881 ) Breeze: F6020556: image.png Breeze Dark: F6020561: image.png

D13899: KMessageWidget: use theme instead of hardcoded colours

rjvbb created this revision. rjvbb added reviewers: Frameworks, VDG. rjvbb added projects: Frameworks, VDG. Restricted Application added a subscriber: kde-frameworks-devel. rjvbb requested review of this revision. REVISION SUMMARY This is a split-off of my D13777