D14006: Fix WebDAV destination header on COPY and MOVE operations

This revision was automatically updated to reflect the committed changes. Closed by commit R241:1f24f49baba4: Fix WebDAV destination header on COPY and MOVE operations (authored by dantti). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14006?vs=37460=41858

D14006: Fix WebDAV destination header on COPY and MOVE operations

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. FullyEncoded makes perfect sense for sending in a protocol implementation. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D14006 To: dantti, dfaure,

D14006: Fix WebDAV destination header on COPY and MOVE operations

dantti added a comment. Well the issue will probably depend on the server, for example Apache2 with Nextcloud it returns forbidden for both operations, in Cloudlyst which does: QUrl::fromEncoded(QStringLiteral("file:///speçiál").toLatin1()).toLocalFile(); you get a file with a

D14006: Fix WebDAV destination header on COPY and MOVE operations

bruns added a comment. In D14006#322626 , @dantti wrote: > Test plan: > > 1. Connecto to a WebDav server > 2. Create a file named "foo" > 3. Try to rename the file to "speçiál" - it should result in "spe" > > The COPY operation has

D14006: Fix WebDAV destination header on COPY and MOVE operations

dantti added a comment. Test plan: 1. Connecto to a WebDav server 2. Create a file named "foo" 3. Try to rename the file to "speçiál" - it should result in "spe" The COPY operation has the same issue but I'm not sure how to test it right now, probably it will also fail if the

D14006: Fix WebDAV destination header on COPY and MOVE operations

bruns added a comment. In D14006#322270 , @dantti wrote: > Ping? This is a pretty obvious fix, desturl is QString which later becomes latin1 loosing characters... Can you add a test plan? Makes it much more obvious how to replicate the

D14006: Fix WebDAV destination header on COPY and MOVE operations

anthonyfieroni added a comment. +1 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14006 To: dantti, dfaure, #frameworks, #dolphin Cc: anthonyfieroni, ngraham, kde-frameworks-devel, michaelh, bruns

D14006: Fix WebDAV destination header on COPY and MOVE operations

dantti added a comment. Ping? This is a pretty obvious fix, desturl is QString which later becomes latin1 loosing characters... REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14006 To: dantti, dfaure, #frameworks, #dolphin Cc: ngraham, kde-frameworks-devel, michaelh,

D14006: Fix WebDAV destination header on COPY and MOVE operations

ngraham added reviewers: Frameworks, Dolphin. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14006 To: dantti, dfaure, #frameworks, #dolphin Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D14006: Fix WebDAV destination header on COPY and MOVE operations

dantti added a comment. In D14006#289680 , @ngraham wrote: > Does this fix any of the bugs here? https://bugs.kde.org/buglist.cgi?component=webdav_id=1529637=kio=--- Nope, it doesn't fix any of them. REPOSITORY R241 KIO REVISION

D14006: Fix WebDAV destination header on COPY and MOVE operations

ngraham added a comment. Does this fix any of the bugs here? https://bugs.kde.org/buglist.cgi?component=webdav_id=1529637=kio=--- REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14006 To: dantti, dfaure Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D14006: Fix WebDAV destination header on COPY and MOVE operations

dantti added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14006 To: dantti, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14006: Fix WebDAV destination header on COPY and MOVE operations

dantti created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. dantti requested review of this revision. REVISION SUMMARY The Destination header must always be QUrl::FullyEncoded so that special characters can