dfaure added a comment.
Possible fix in https://phabricator.kde.org/D16020
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D14072
To: jtamate, dfaure, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
dfaure added a comment.
More generally, please please run the unittests after changing a class. I
hate that I currently am the one doing this, on the day of the release, which
forces me to bugfix such things, or delay the release.
REPOSITORY
R241 KIO
REVISION DETAIL
dfaure added a comment.
This commit breaks kfileplacesmodeltest.
$ bin/kfileplacesmodeltest testInitialState testInitialList
testInternalBookmarksHaveIds
- Start testing of KFilePlacesModelTest *
Config: Using QtTest library 5.12.0, Qt 5.12.0 (x86_64-little_endian-lp64
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:2b52b47211a6: Dont try to restore invalid user
places (authored by jtamate).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D14072?vs=41879=41907
REVISION DETAIL
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D14072
To: jtamate, dfaure, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
jtamate updated this revision to Diff 41879.
jtamate added a comment.
Continue processing the XML with invalid urls.
And a trivial code deduplication, I couldn't resist.
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D14072?vs=37631=41879
REVISION DETAIL
dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.
Shouldn't this skip the invalid bookmark rather than abort completely ?
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D14072
To: jtamate, dfaure,
