D14158: Avoid a kio-mtp crash when trying to add a blocked device to the device cache

2018-07-21 Thread Jaime Torres Amate
This revision was automatically updated to reflect the committed changes. Closed by commit R320:0cc17f0c1b91: Avoid a kio-mtp crash when trying to add a blocked device to the device cache (authored by jtamate). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE

D14158: Avoid a kio-mtp crash when trying to add a blocked device to the device cache

2018-07-21 Thread Elvis Angelaccio
elvisangelaccio accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D14158 To: jtamate, #frameworks, elvisangelaccio Cc: broulik

D14158: Avoid a kio-mtp crash when trying to add a blocked device to the device cache

2018-07-16 Thread Kai Uwe Broulik
broulik added a comment. Should this show an error to the user? I could also imagine this interfering with thumbnail generation when viewing the device REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D14158 To: jtamate, #frameworks Cc: broulik

D14158: Avoid a kio-mtp crash when trying to add a blocked device to the device cache

2018-07-16 Thread Jaime Torres Amate
jtamate created this revision. jtamate added a reviewer: Frameworks. jtamate requested review of this revision. REVISION SUMMARY When the device is blocked, for example by amarok mtp plugin, the result of LIBMTP_Open_Raw_Device_Uncached(rawDevice) is nullptr and