D14270: CoffeeScript: fix templates in embedded JavaScript code & add escapes

2018-08-03 Thread Nibaldo González
nibags closed this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14270 To: nibags, dhaumann, cullmann, #framework_syntax_highlighting, #kate Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars,

D14270: CoffeeScript: fix templates in embedded JavaScript code & add escapes

2018-07-31 Thread Nibaldo González
nibags added a comment. Now I have access to commits... but apparently, you have to accept the latest revision to do so :( REPOSITORY R216 Syntax Highlighting BRANCH jsemb-coffeescript REVISION DETAIL https://phabricator.kde.org/D14270 To: nibags, dhaumann, cullmann,

D14270: CoffeeScript: fix templates in embedded JavaScript code & add escapes

2018-07-26 Thread Nibaldo González
nibags updated this revision to Diff 38476. nibags added a comment. - Increase file version (to 6). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14270?vs=38194=38476 BRANCH jsemb-coffeescript REVISION DETAIL

D14270: CoffeeScript: fix templates in embedded JavaScript code & add escapes

2018-07-22 Thread Dominik Haumann
dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Besides version number, lgtm. REPOSITORY R216 Syntax Highlighting BRANCH jsemb-coffeescript REVISION DETAIL https://phabricator.kde.org/D14270 To: nibags, dhaumann, cullmann,

D14270: CoffeeScript: fix templates in embedded JavaScript code & add escapes

2018-07-22 Thread Dominik Haumann
dhaumann added a comment. Makes sense. Can you also increase the version number in the language element? BTW, do you have commit access? Given your frequent updates, it makes sense if you can push yourself. REPOSITORY R216 Syntax Highlighting REVISION DETAIL

D14270: CoffeeScript: fix templates in embedded JavaScript code & add escapes

2018-07-22 Thread Nibaldo González
nibags edited the summary of this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14270 To: nibags, dhaumann, cullmann, #framework_syntax_highlighting, #kate Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking,

D14270: CoffeeScript: fix templates in embedded JavaScript code & add escapes

2018-07-22 Thread Nibaldo González
nibags edited the summary of this revision. nibags added reviewers: dhaumann, cullmann, Framework: Syntax Highlighting, Kate. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14270 To: nibags, dhaumann, cullmann, #framework_syntax_highlighting, #kate Cc:

D14270: CoffeeScript: fix templates in embedded JavaScript code & add escapes

2018-07-22 Thread Nibaldo González
nibags created this revision. Restricted Application added projects: Kate, Frameworks. Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REVISION SUMMARY In CoffeeScript, the character ` (grave accent) is used to insert