glennw added a comment.
Yes, you got the address and the reference correct - that sounds like it
would have been quite the project!
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D14435
To: glennw, cfeck, mlaurent
Cc: ngraham, kde-frameworks-devel, michaelh,
cfeck added a comment.
Thanks, committed. I hope I got the correct address from your bugzilla
comment.
Offtopic: When I started understanding BOOPSI objects, I was a bit
disappointed that Window and Screen objects in intuition.library where not
BOOPSI objects. I re-sourced the complete
This revision was automatically updated to reflect the committed changes.
Closed by commit R236:628c5b1335a2: Fix KTimeComboBox input mask for AM/PM
times (authored by glennw, committed by cfeck).
REPOSITORY
R236 KWidgetsAddons
CHANGES SINCE LAST UPDATE
mlaurent accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D14435
To: glennw, cfeck, mlaurent
Cc: ngraham, kde-frameworks-devel, michaelh, bruns
glennw updated this revision to Diff 38890.
glennw added a comment.
Switched test to use QVERIFY().
REPOSITORY
R236 KWidgetsAddons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D14435?vs=38748=38890
REVISION DETAIL
https://phabricator.kde.org/D14435
AFFECTED FILES
mlaurent requested changes to this revision.
mlaurent added a comment.
This revision now requires changes to proceed.
For me it's ok after using QVERIFY...
INLINE COMMENTS
> ktimecomboboxtest.cpp:198
> +QString mask = m_combo->lineEdit()->inputMask();
> +
glennw updated this revision to Diff 38748.
glennw added a comment.
Updated to include test for 24hr locales.
REPOSITORY
R236 KWidgetsAddons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D14435?vs=38685=38748
REVISION DETAIL
https://phabricator.kde.org/D14435
AFFECTED FILES
mlaurent requested changes to this revision.
mlaurent added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> ktimecomboboxtest.cpp:198
> +QString mask = m_combo->lineEdit()->inputMask();
> +QCOMPARE(mask.contains(QLatin1String("aa")), true);
> +delete
glennw updated this revision to Diff 38685.
glennw added a comment.
Added an autotest to ensure that the line edit mask is updated correctly.
A couple of notes about the test results below:
- I tried to set the current locale in the new test to ensure it reproduces.
The setLocale()
mlaurent requested changes to this revision.
mlaurent added a comment.
This revision now requires changes to proceed.
could you provide an autotest for it please ?
(see autotest/ktimecomboboxtest.cpp)
Thanks
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
glennw added reviewers: cfeck, mlaurent.
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D14435
To: glennw, cfeck, mlaurent
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
glennw created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
glennw requested review of this revision.
REVISION SUMMARY
In some cases, the strings returned from amText() and
pmText() may differ in case to
12 matches
Mail list logo
