D14579: api for multi level kcms

2018-08-08 Thread Marco Martin
mart abandoned this revision. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D14579 To: mart, #plasma, #frameworks Cc: abetts, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D14579: api for multi level kcms

2018-08-07 Thread Andres Betts
abetts added a comment. Awesome! REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D14579 To: mart, #plasma, #frameworks Cc: abetts, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D14579: api for multi level kcms

2018-08-07 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > kcmodule.cpp:59 > QString m_ExportText; > +QList _levelTitles; > +uint _currentLevel = 0; `QStringList`? > kcmodule.h:273 > + */ > +uint depth() const; > + `uint` is quite unusual for our APIs, isn't it? > kcmodule.h:286 >

D14579: api for multi level kcms

2018-08-03 Thread Marco Martin
mart added a reviewer: Frameworks. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D14579 To: mart, #plasma, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14579: api for multi level kcms

2018-08-03 Thread Marco Martin
mart added a dependent revision: D14580: support for multi pages kcms. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D14579 To: mart, #plasma Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14579: api for multi level kcms

2018-08-03 Thread Marco Martin
mart created this revision. mart added a reviewer: Plasma. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. mart requested review of this revision. REVISION SUMMARY Support the concept of multi level kcms: systemsettings and