D14757: Warn user before copy/move operation if available space is not enough

dfaure added a comment. Looks OK now. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14757 To: shubham, pino, dfaure, broulik, ngraham Cc: ngraham, dfaure, pino, kde-frameworks-devel, michaelh, bruns

D14757: Warn user before copy/move operation if available space is not enough

shubham added a comment. Sorry for that, will take care of that in future. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14757 To: shubham, pino, dfaure, broulik, ngraham Cc: ngraham, dfaure, pino, kde-frameworks-devel, michaelh, bruns

D14757: Warn user before copy/move operation if available space is not enough

ngraham added a comment. Yes, but they still hadn't approved the current version. :) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14757 To: shubham, pino, dfaure, broulik, ngraham Cc: ngraham, dfaure, pino, kde-frameworks-devel, michaelh, bruns

D14757: Warn user before copy/move operation if available space is not enough

shubham added a comment. @ngraham I thought those "request changes" were against my prior diffs REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14757 To: shubham, pino, dfaure, broulik, ngraham Cc: ngraham, dfaure, pino, kde-frameworks-devel, michaelh, bruns

D14757: Warn user before copy/move operation if available space is not enough

ngraham added a comment. @shubham, in the future, when there are still reviewers who have marked their status as "Request Changes", please wait for them to approve before pushing. Since that didn't happen this time, if @pino or @dfaure have any remaining concerns with this patch, please

D14757: Warn user before copy/move operation if available space is not enough

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R241:5a48bd21212c: Warn user before copy/move operation if available space is not enough (authored by shubham). REPOSITORY

D14757: Warn user before copy/move operation if available space is not enough

ngraham accepted this revision. ngraham added a comment. That's better: F6268143: Better.png FWIW, I've submitted a patch to slightly improve the error message: D15557 @pino and @dfaure, are you good

D14757: Warn user before copy/move operation if available space is not enough

shubham updated this revision to Diff 41765. shubham added a comment. addressed broulik's comments REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14757?vs=41764=41765 REVISION DETAIL https://phabricator.kde.org/D14757 AFFECTED FILES src/core/copyjob.cpp

D14757: Warn user before copy/move operation if available space is not enough

shubham marked 2 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14757 To: shubham, pino, dfaure, broulik, ngraham Cc: ngraham, dfaure, pino, kde-frameworks-devel, michaelh, bruns

D14757: Warn user before copy/move operation if available space is not enough

broulik added inline comments. INLINE COMMENTS > copyjob.cpp:887 > qCDebug(KIO_COPYJOB_DEBUG)<<"Stating finished. To > copy:"< -//TODO warn user beforehand if space is not enough > +if (m_totalSize > m_freeSpace) { > +q->setError(ERR_DISK_FULL); Please

D14757: Warn user before copy/move operation if available space is not enough

shubham updated this revision to Diff 41764. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14757?vs=41761=41764 REVISION DETAIL https://phabricator.kde.org/D14757 AFFECTED FILES src/core/copyjob.cpp To: shubham, pino, dfaure, broulik, ngraham Cc: ngraham,

D14757: Warn user before copy/move operation if available space is not enough

ngraham added a comment. Perfect, thanks! I did some investigation and this oddly-formed string is actually built by KIO itself, in `core/job_error.cpp`: case KIO::ERR_DISK_FULL: result = i18n("Could not write file %1.\nDisk full.", errorText); break; It looks

D14757: Warn user before copy/move operation if available space is not enough

shubham updated this revision to Diff 41761. shubham added a comment. done above requested change REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14757?vs=41751=41761 REVISION DETAIL https://phabricator.kde.org/D14757 AFFECTED FILES src/core/copyjob.cpp

D14757: Warn user before copy/move operation if available space is not enough

ngraham added a comment. Yay, it works now! If I try to copy a folder that is too big, it stops immediately before anything happens, and the following is displayed in Dolphin: F6268053: It works, mostly.png The weird display is probably a bug

D14757: Warn user before copy/move operation if available space is not enough

shubham updated this revision to Diff 41751. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14757?vs=41747=41751 REVISION DETAIL https://phabricator.kde.org/D14757 AFFECTED FILES src/core/copyjob.cpp To: shubham, pino, dfaure, broulik, ngraham Cc: ngraham,

D14757: Warn user before copy/move operation if available space is not enough

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. You forgot the error line. :) It needs `q->setError(ERR_DISK_FULL);` before `setErrorText()`. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14757 To:

D14757: Warn user before copy/move operation if available space is not enough

shubham updated this revision to Diff 41747. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14757?vs=41746=41747 REVISION DETAIL https://phabricator.kde.org/D14757 AFFECTED FILES src/core/copyjob.cpp To: shubham, pino, dfaure, broulik Cc: ngraham, dfaure,

D14757: Warn user before copy/move operation if available space is not enough

ngraham added a comment. Looking better, thanks! I will test shortly. I have one string change suggestion; can we change it to: There is not enough space available at %1 to hold the file.%2 are required but only %3 are available. REPOSITORY R241 KIO REVISION DETAIL

D14757: Warn user before copy/move operation if available space is not enough

shubham marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14757 To: shubham, pino, dfaure, broulik Cc: ngraham, dfaure, pino, kde-frameworks-devel, michaelh, bruns

D14757: Warn user before copy/move operation if available space is not enough

shubham marked 3 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14757 To: shubham, pino, dfaure, broulik Cc: ngraham, dfaure, pino, kde-frameworks-devel, michaelh, bruns

D14757: Warn user before copy/move operation if available space is not enough

shubham updated this revision to Diff 41746. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14757?vs=41655=41746 REVISION DETAIL https://phabricator.kde.org/D14757 AFFECTED FILES src/core/copyjob.cpp To: shubham, pino, dfaure, broulik Cc: ngraham, dfaure,

D14757: Warn user before copy/move operation if available space is not enough

ngraham added a comment. We don't actually need to create a messagebox because it's up to the caller to display the error in an appropriate manner. For example, Dolphin shows errors inline rather than with dialog boxes. So we shouldn't create a messagebox at all. Let's see if we can

D14757: Warn user before copy/move operation if available space is not enough

shubham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14757 To: shubham, pino, dfaure, broulik Cc: dfaure, pino, kde-frameworks-devel, michaelh, ngraham, bruns

D14757: Warn user before copy/move operation if available space is not enough

shubham marked 3 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14757 To: shubham, pino, dfaure, broulik Cc: dfaure, pino, kde-frameworks-devel, michaelh, ngraham, bruns

D14757: Warn user before copy/move operation if available space is not enough

shubham retitled this revision from "Warn user before copy operation if available space is not enough" to "Warn user before copy/move operation if available space is not enough". REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14757 To: shubham, pino, dfaure, broulik Cc: