D14826: inline note interface wip #2

brauch closed this revision. brauch added a comment. commit 4ea5fee0afe5c76bbee07563c23ede808aa059de Author: Sven Brauch Date: Tue Aug 14 12:31:31 2018 +0200 Add inline note interface Original patch by Michal Srb. The inline note interface provides a way to rende

D14826: inline note interface wip #2

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Avoiding the QObject inheritance requires some ugly QObject casts, therefore we keep that ATM. We merge it that way and talk tomorrow morning once more about that detail. REPOSITORY

D14826: inline note interface wip #2

cullmann added a comment. I think the Provider needs not to be an QObject, just an interface, IMHO. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D14826 To: brauch, michalsrb, dhaumann, cullmann Cc: anthonyfieroni, kwrite-devel, kde-frameworks-devel, michaelh, ke

D14826: inline note interface wip #2

brauch updated this revision to Diff 39889. brauch added a comment. update license text REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14826?vs=39888&id=39889 BRANCH inlinenotes REVISION DETAIL https://phabricator.kde.org/D14826 AFFECTED FILES s

D14826: inline note interface wip #2

brauch updated this revision to Diff 39888. brauch marked 21 inline comments as done. brauch added a comment. Implement Dominik's suggestions REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14826?vs=39815&id=39888 BRANCH inlinenotes REVISION DETAIL

D14826: inline note interface wip #2

dhaumann added a comment. I think one more iteration, and this can be merged. Can you look into this again? INLINE COMMENTS > CMakeLists.txt:5 >AnnotationInterface CodeCompletionModelControllerInterface MovingCursor > Range TextHintInterface > - Cursor MarkInterface MovingInterface > +

D14826: inline note interface wip #2

brauch updated this revision to Diff 39815. brauch added a comment. address Dominik's suggestion and split focus handling and click handling REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14826?vs=39802&id=39815 BRANCH inlinenotes REVISION DETAIL h

D14826: inline note interface wip #2

dhaumann added a comment. I think this goes into the right direction :-) INLINE COMMENTS > inlinenoteinterface.h:2 > +/* This file is part of the KDE libraries > + > + This library is free software; you can redistribute it and/or author missing > inlinenoteinterface.h:73 > + * \see Inline

D14826: inline note interface wip #2

cullmann added a comment. I would not implement any function inline and just hide their implementation in the .cpp to be able to alter them later (for InlineNote). For the activation, I would like to be able to differentiate between the different mouse buttons like the qt mousepressed stuff

D14826: inline note interface wip #2

brauch updated this revision to Diff 39802. brauch added a comment. I added the rest of the interaction interface (click, mouseover) and reduced the API a bit by moving a few hints into the InlineNote object. Only thing I still intend to change about the API would be that we use the

D14826: inline note interface wip #2

brauch updated this revision to Diff 39721. brauch added a comment. add noteActivated notifier function When a note is mouse-overed or clicked, a function on the note provider is called, giving the point it was hovered or clicked in note coordinates, the type of event, and the note the

D14826: inline note interface wip #2

brauch added a comment. Thanks for the feedback! I will try doing a few more things with this interace and then maybe discuss again with the other kate people here at Akademy about which one they like better. About the tracking, I don't think anything is needed on the side of the interf

D14826: inline note interface wip #2

michalsrb added a comment. Thank you for working on this. This interface would work for the kdev-sourceinfo use case just as well as the old one. I think the problem with the old interface that you described is valid. This version gives more flexibility to the `InlineNotesProvider` with

D14826: inline note interface wip #2

brauch updated this revision to Diff 39692. brauch added a comment. add missing files REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14826?vs=39682&id=39692 BRANCH inlinenotes REVISION DETAIL https://phabricator.kde.org/D14826 AFFECTED FILES src

D14826: inline note interface wip #2

brauch added a comment. Sample patch for KDevelop's problem highlighter plus screenshot: F6192637: hl.png F6192639: inline-problems.diff REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org

D14826: inline note interface wip #2

brauch edited the summary of this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D14826 To: brauch, michalsrb, dhaumann, cullmann Cc: anthonyfieroni, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars, dhauma

D14826: inline note interface wip #2

anthonyfieroni added inline comments. INLINE COMMENTS > katerenderer.cpp:765 > +// Draw inline notes > +auto inlineNotes = m_view->inlineNotes(range->line()); > +foreach (const KTextEditor::InlineNote& inlineNote, inlineNotes) { const > katerenderer.cpp:766 > +au

D14826: inline note interface wip #2

brauch added reviewers: michalsrb, dhaumann, cullmann. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D14826 To: brauch, michalsrb, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars, dhaumann

D14826: inline note interface wip #2

brauch created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. brauch requested review of this revision. REPOSITORY R39 KTextEditor BRANCH master REVISION DETAIL https://phabricator.kde.org/D14826 AFFECTED FILES src/d