This revision was automatically updated to reflect the committed changes.
Closed by commit R240:1790a6994a35: Bindings: Add support for scoped enums
(authored by bruns).
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D14908?vs=40250=40390
REVISION
mpyne accepted this revision.
mpyne added a comment.
This revision is now accepted and ready to land.
LGTM and there's been plenty of time for a NAK. I say let's commit.
REPOSITORY
R240 Extra CMake Modules
BRANCH
scoped_enum
REVISION DETAIL
https://phabricator.kde.org/D14908
To:
bruns updated this revision to Diff 40250.
bruns edited the summary of this revision.
bruns added a comment.
Update minimum LLVM version in CMake check
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D14908?vs=39943=40250
BRANCH
scoped_enum
bruns planned changes to this revision.
bruns added a comment.
Ok, then I will update the requirements in the clang check.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D14908
To: bruns, #frameworks
Cc: mpyne, kde-frameworks-devel, kde-buildsystem,
mpyne added a comment.
As long as older versions of LLVM result in the Python binding generation
step being skipped completely (we already check for libclang in the
find-package for this, right?), I don't think the dependency increase is a
problem.
REPOSITORY
R240 Extra CMake Modules
bruns added a comment.
This raises the minimum requirement to LLVM 5.0:
http://releases.llvm.org/5.0.0/tools/clang/docs/ReleaseNotes.html
LLVM 5.0 was released 2017-09-07:
http://lists.llvm.org/pipermail/llvm-announce/2017-September/75.html
REPOSITORY
R240 Extra CMake Modules
bruns added a comment.
Compilation succeeds again, and the generated code looks sane. I have not
actually tested it, though.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D14908
To: bruns, #frameworks
Cc: mpyne, kde-frameworks-devel, kde-buildsystem,
mpyne added a comment.
LGTM but then I don't use the Python bindings. Have you already tried the
kcoreaddons build to see if this makes it work where it had failed before?
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D14908
To: bruns, #frameworks
Cc:
bruns created this revision.
bruns added a reviewer: Frameworks.
Herald added projects: Frameworks, Build System.
Herald added subscribers: kde-buildsystem, kde-frameworks-devel.
bruns requested review of this revision.
REVISION SUMMARY
Keep the enum intact by emitting the class keyword in case
