broulik added a comment.
KWin is fixed in 5.12, 5.13 and master branch, thanks for bringing this to
our attention
REPOSITORY
R249 KI18n
REVISION DETAIL
https://phabricator.kde.org/D14922
To: aacid, dfaure
Cc: broulik, kwin, ahartmetz, dfaure, ltoscano, ilic, kde-frameworks-devel,
ahartmetz added a subscriber: kwin.
ahartmetz added a comment.
@kwin
REPOSITORY
R249 KI18n
REVISION DETAIL
https://phabricator.kde.org/D14922
To: aacid, dfaure
Cc: kwin, ahartmetz, dfaure, ltoscano, ilic, kde-frameworks-devel, michaelh,
ngraham, bruns
ahartmetz added a comment.
This change makes kwin_x11 crash on startup. Please fix kwin or degrade this
to a warning.
REPOSITORY
R249 KI18n
REVISION DETAIL
https://phabricator.kde.org/D14922
To: aacid, dfaure
Cc: ahartmetz, dfaure, ltoscano, ilic, kde-frameworks-devel, michaelh,
aacid closed this revision.
REPOSITORY
R249 KI18n
REVISION DETAIL
https://phabricator.kde.org/D14922
To: aacid, dfaure
Cc: dfaure, ltoscano, ilic, kde-frameworks-devel, michaelh, ngraham, bruns
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.
Qt itself tends to write "QCoreApplication" in such warnings instead of
Q*Application, but OK.
REPOSITORY
R249 KI18n
BRANCH
arcpatch-D14922
REVISION DETAIL
aacid updated this revision to Diff 40005.
aacid added a comment.
Use Q_ASSERT_X
REPOSITORY
R249 KI18n
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D14922?vs=39980=40005
BRANCH
arcpatch-D14922
REVISION DETAIL
https://phabricator.kde.org/D14922
AFFECTED FILES
dfaure added inline comments.
INLINE COMMENTS
> kcatalog.cpp:188
> if (language != currentLanguage || !bindDone) {
> +Q_ASSERT(QCoreApplication::instance() && "You need to instantiate a
> Q*Application before using KCatalog");
> +if (!QCoreApplication::instance()) {
aacid added subscribers: ilic, ltoscano.
REPOSITORY
R249 KI18n
REVISION DETAIL
https://phabricator.kde.org/D14922
To: aacid
Cc: ltoscano, ilic, kde-frameworks-devel, michaelh, ngraham, bruns
aacid created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
aacid requested review of this revision.
REVISION SUMMARY
QCoreApplication init calls
setlocale(LC_ALL, "");
that is crucial for gettext to work, so assert if
the user
