This revision was automatically updated to reflect the committed changes.
Closed by commit R241:9e706796b152: Display mounted file system type and
mounted from fields in properties dialog (authored by shubham).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D15000?
broulik accepted this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D15000
To: shubham, dfaure, broulik, ngraham, #frameworks, cfeck
Cc: ngraham, broulik, kde-frameworks-devel, michaelh, bruns
shubham added a comment.
@cfeck @broulik any comments on this?
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D15000
To: shubham, dfaure, broulik, ngraham, #frameworks, cfeck
Cc: ngraham, broulik, kde-frameworks-devel, michaelh, bruns
ngraham accepted this revision.
ngraham added reviewers: Frameworks, cfeck.
ngraham added a comment.
This revision is now accepted and ready to land.
Works great and looks fine to me, and the code seems sensible too given that
this dialog is currently implemented with a GridLayout. I'd like to
shubham added a comment.
ping?
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D15000
To: shubham, dfaure, broulik, ngraham
Cc: ngraham, broulik, kde-frameworks-devel, michaelh, bruns
shubham retitled this revision from "Display mounted file system type in
properties dialog" to "Display mounted file system type and mounted from fields
in properties dialog".
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D15000
To: shubham, dfaure, broulik, ngraham
Cc: n
