dhaumann added a comment.
The old wildcard matcher existed for performance reasons. Did you check?
PS: When doing review requests, could you please have a nice subject, and not
put very long lines into its stead? :-p Especially since this line will also
appear in Davids release notes?
R
cullmann updated this revision to Diff 40429.
cullmann added a comment.
improve definitionForName code, already for matching take into account the
priority
that saves some matching time and avoid later sorting
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabri
cullmann updated this revision to Diff 40428.
cullmann added a comment.
all code is now MIT
only non-MIT parts are e.g. some generator scripts for highlighting and many
highlighting data files
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D15
cullmann added a comment.
Rational for the static convertExtensionsToRegularExpression method: Allows
to nice unit tests + allows e.g. KTextEditor to use that later, too, as
replacement for its own copy of the wildcard matcher code for the modelines.
REPOSITORY
R216 Syntax Highlighting
RE
cullmann created this revision.
cullmann added reviewers: vkrause, dhaumann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
cullmann requested review of this revision.
REVISION SUMMARY
...will never match as it tried to match the file path