D15194: Draw a line separating PlasmaComponents tab bar from its content area

ngraham abandoned this revision. ngraham added a comment. Not needed; we can and arguably should do all of this only in Kickoff since this style isn't guaranteed to look good everywhere. We'll do everything in D15206 . REPOSITORY R242 Plasma Framework

D15194: Draw a line separating PlasmaComponents tab bar from its content area

dhaumann added a comment. Hm, two separator lines, even touching each other sounds like a hack. Is there no better way? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D15194 To: ngraham, #plasma, #vdg Cc: dhaumann, romangg, abetts,

D15194: Draw a line separating PlasmaComponents tab bar from its content area

ngraham updated this revision to Diff 42763. ngraham added a comment. Make the separator line touch the line drawn by the scrollview when it's scrollable REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15194?vs=40798=42763 BRANCH

D15194: Draw a line separating PlasmaComponents tab bar from its content area

ngraham planned changes to this revision. ngraham added a comment. In D15194#328915 , @abetts wrote: > In D15194#328651 , @romangg wrote: > > > If there are more items than space available in the

D15194: Draw a line separating PlasmaComponents tab bar from its content area

abetts added a comment. In D15194#328651 , @romangg wrote: > If there are more items than space available in the list a line is drawn already now to indicate that there are more items to come by scrolling down. Does this not conflict with the

D15194: Draw a line separating PlasmaComponents tab bar from its content area

romangg added a comment. If there are more items than space available in the list a line is drawn already now to indicate that there are more items to come by scrolling down. Does this not conflict with the new line? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D15194: Draw a line separating PlasmaComponents tab bar from its content area

ngraham added a comment. So I've got a +1 from VDG. Any opinions from someone in #plasma ? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D15194 To: ngraham, #plasma, #vdg Cc: abetts, kde-frameworks-devel,

D15194: Draw a line separating PlasmaComponents tab bar from its content area

abetts added a comment. +1 REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D15194 To: ngraham, #plasma, #vdg Cc: abetts, kde-frameworks-devel, michaelh, ngraham, bruns

D15194: Draw a line separating PlasmaComponents tab bar from its content area

ngraham added a reviewer: VDG. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D15194 To: ngraham, #plasma, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15194: Draw a line separating PlasmaComponents tab bar from its content area

ngraham added a comment. Also, if it's preferable to position the item with anchors rather than specifying with x and y, I can do that too: anchors { left: tabPosition == Qt.LeftEdge ? undefined : buttonCutter.left right: tabPosition == Qt.RightEdge ? undefined :

D15194: Draw a line separating PlasmaComponents tab bar from its content area

ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D15194 To: ngraham, #plasma Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15194: Draw a line separating PlasmaComponents tab bar from its content area

ngraham added a comment. I implemented this with the `horizontal-line`/`vertical-line` SVG items to follow the general pattern that I noticed, but I'm not super thrilled with the resulting legibility; it seems a bit too light, and was almost invisible at 1px tall. I also tried a 1px tall

D15194: Draw a line separating PlasmaComponents tab bar from its content area

ngraham created this revision. ngraham added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY This patch implements one of the ideas we came up with in D15011