cullmann added a comment.
Done: https://phabricator.kde.org/R40:7e3292bffc3012d20c0d4df2de0b1a8bab0ca886
Removed mentioning of "dynamic" for contexts, too, that is no longer used at
all.
Should purge it from XSD, too.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
dhaumann added a comment.
@cullmann Can you update the docbook in kate.git/doc/ so that the
documentation about writing syntax highlighting files keeps up to date also for
the dynamic changes?
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D15211
To:
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:96ec243322ef: ::match and ::doMatch = const (authored
by cullmann).
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D15211?vs=40836=40845
REVISION
vkrause accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R216 Syntax Highlighting
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D15211
To: cullmann, vkrause, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham,
cullmann updated this revision to Diff 40836.
cullmann added a comment.
lower m_dynamic to the three rules that support it at all
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D15211?vs=40835=40836
BRANCH
master
REVISION DETAIL
cullmann updated this revision to Diff 40835.
cullmann added a comment.
disallow dynamic for stuff we didn't implement
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D15211?vs=40834=40835
BRANCH
master
REVISION DETAIL
cullmann updated this revision to Diff 40834.
cullmann added a comment.
avoid duplicate storage of pattern
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D15211?vs=40833=40834
BRANCH
master
REVISION DETAIL
cullmann created this revision.
cullmann added reviewers: vkrause, dhaumann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
cullmann requested review of this revision.
REVISION SUMMARY
make ::match and ::doMatch const
ATM the keyword