D15220: implement more basic tags for taglibwriter

This revision was automatically updated to reflect the committed changes. Closed by commit R286:0f16dd4d4cbf: implement more basic tags for taglibwriter (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15220?vs=41856=42518

D15220: implement more basic tags for taglibwriter

bruns accepted this revision. bruns added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > astippich wrote in taglibwriter.cpp:67 > taglib only allows unsigned int for year and track, so I don't know how > that's possible with taglib. > I added checks to

D15220: implement more basic tags for taglibwriter

astippich added a dependent revision: D15715: remove own implementation of QString to TString conversion for taglibwriter. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D15220 To: astippich, mgallien, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov,

D15220: implement more basic tags for taglibwriter

astippich added a dependent revision: D15704: increase test coverage of taglibwriter. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D15220 To: astippich, mgallien, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham,

D15220: implement more basic tags for taglibwriter

astippich added a comment. In D15220#325580 , @bruns wrote: > Can you add some Unicode exercising tests? I plan to extend the tests in a later patch, if you don't mind, I would prefer to add this there. INLINE COMMENTS > bruns wrote in

D15220: implement more basic tags for taglibwriter

astippich updated this revision to Diff 41856. astippich added a comment. - check for values greater than zero for tracknumber and year REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15220?vs=40861=41856 BRANCH taglib_write REVISION DETAIL

D15220: implement more basic tags for taglibwriter

bruns added a comment. Can you add some Unicode exercising tests? INLINE COMMENTS > taglibwritertest.cpp:18 > > static QString t2q(const TagLib::String& t) > { Side note - bad implementation, see D13700 Also see inverse q2t in taglibwritertest.cpp

D15220: implement more basic tags for taglibwriter

astippich updated this revision to Diff 40861. astippich added a comment. - use different test data REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15220?vs=40858=40861 BRANCH taglib_write REVISION DETAIL https://phabricator.kde.org/D15220

D15220: implement more basic tags for taglibwriter

astippich created this revision. astippich added reviewers: mgallien, bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY implement all basic tags directly provided by taglib for