D15309: [Calendar] Wrap day name index around

2018-09-06 Thread Chris Holland
Zren added a comment. Nice thinking on using `repeater.count` instead of the hardcoded `7`! Hmm, was worried `days.count` would trigger `onCountChanged` every time a delegate is made (count=1, count=2, etc), but it seems that the `delegate.text` is only calculated twice (delegate creatio

D15309: [Calendar] Wrap day name index around

2018-09-06 Thread Kai Uwe Broulik
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R242:020d3e3ebea5: [Calendar] Wrap day name index around (authored by broulik). REPOSITORY R242 Plasma Framework (Library

D15309: [Calendar] Wrap day name index around

2018-09-06 Thread Safa Alfulaij
safaalfulaij added a comment. I thought that this is a feature/cool look :D Thanks a lot! REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D15309 To: broulik, #plasma, Zren Cc: safaalfulaij, kde-frameworks-devel, michaelh, ngraham, bruns

D15309: [Calendar] Wrap day name index around

2018-09-06 Thread Kai Uwe Broulik
broulik edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D15309 To: broulik, #plasma, Zren Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15309: [Calendar] Wrap day name index around

2018-09-06 Thread Kai Uwe Broulik
broulik added a reviewer: Zren. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D15309 To: broulik, #plasma, Zren Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15309: [Calendar] Wrap day name index around

2018-09-06 Thread Kai Uwe Broulik
broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Otherwise when the week starts on a day other than Sunday or Monday we access invalid