D15353: Use _NET_WM_WINDOW_TYPE_COMBO instead of _NET_WM_WINDOW_TYPE_COMBOBOX

This revision was automatically updated to reflect the committed changes. Closed by commit R278:9658d727bdae: Use _NET_WM_WINDOW_TYPE_COMBO instead of _NET_WM_WINDOW_TYPE_COMBOBOX (authored by zzag). REPOSITORY R278 KWindowSystem CHANGES SINCE LAST UPDATE

D15353: Use _NET_WM_WINDOW_TYPE_COMBO instead of _NET_WM_WINDOW_TYPE_COMBOBOX

romangg accepted this revision. This revision is now accepted and ready to land. REPOSITORY R278 KWindowSystem BRANCH use-combo-instead-of-combobox REVISION DETAIL https://phabricator.kde.org/D15353 To: zzag, #kwin, romangg Cc: romangg, aacid, kde-frameworks-devel, michaelh, ngraham,

D15353: Use _NET_WM_WINDOW_TYPE_COMBO instead of _NET_WM_WINDOW_TYPE_COMBOBOX

zzag added a comment. Ping. REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D15353 To: zzag, #kwin Cc: romangg, aacid, kde-frameworks-devel, michaelh, ngraham, bruns

D15353: Use _NET_WM_WINDOW_TYPE_COMBO instead of _NET_WM_WINDOW_TYPE_COMBOBOX

zzag added a comment. Ping. REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D15353 To: zzag, #kwin Cc: romangg, aacid, kde-frameworks-devel, michaelh, ngraham, bruns

D15353: Use _NET_WM_WINDOW_TYPE_COMBO instead of _NET_WM_WINDOW_TYPE_COMBOBOX

zzag added a comment. In D15353#329431 , @romangg wrote: > Whoops, yea. My fault. I think it's fine to replace the name, since Qt/GTK use the correct one and normally apps use these libs instead of setting such properties directly. Can

D15353: Use _NET_WM_WINDOW_TYPE_COMBO instead of _NET_WM_WINDOW_TYPE_COMBOBOX

romangg added a comment. Whoops, yea. My fault. I think it's fine to replace the name, since Qt/GTK use the correct one and normally apps use these libs instead of setting such properties directly. REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D15353 To:

D15353: Use _NET_WM_WINDOW_TYPE_COMBO instead of _NET_WM_WINDOW_TYPE_COMBOBOX

zzag added a comment. In D15353#329424 , @romangg wrote: > ... to KWindowSystem as well? Isn't it KWindowSystem repo? (maybe, I don't understand your question) REPOSITORY R278 KWindowSystem REVISION DETAIL

D15353: Use _NET_WM_WINDOW_TYPE_COMBO instead of _NET_WM_WINDOW_TYPE_COMBOBOX

romangg added a comment. In D15353#323028 , @zzag wrote: > In D15353#322991 , @aacid wrote: > > > I'm not a KWindowSystem developer so take this with a grain of salt, but maybe it makes sense to

D15353: Use _NET_WM_WINDOW_TYPE_COMBO instead of _NET_WM_WINDOW_TYPE_COMBOBOX

zzag added a comment. Ping. REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D15353 To: zzag, #kwin Cc: aacid, kde-frameworks-devel, michaelh, ngraham, bruns

D15353: Use _NET_WM_WINDOW_TYPE_COMBO instead of _NET_WM_WINDOW_TYPE_COMBOBOX

zzag added a comment. Ping. REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D15353 To: zzag, #kwin Cc: aacid, kde-frameworks-devel, michaelh, ngraham, bruns

D15353: Use _NET_WM_WINDOW_TYPE_COMBO instead of _NET_WM_WINDOW_TYPE_COMBOBOX

zzag added a comment. In D15353#322991 , @aacid wrote: > I'm not a KWindowSystem developer so take this with a grain of salt, but maybe it makes sense to still support the old name in case someone is really using it and add the new one as a

D15353: Use _NET_WM_WINDOW_TYPE_COMBO instead of _NET_WM_WINDOW_TYPE_COMBOBOX

aacid added a comment. I'm not a KWindowSystem developer so take this with a grain of salt, but maybe it makes sense to still support the old name in case someone is really using it and add the new one as a synonym? REPOSITORY R278 KWindowSystem REVISION DETAIL

D15353: Use _NET_WM_WINDOW_TYPE_COMBO instead of _NET_WM_WINDOW_TYPE_COMBOBOX

zzag created this revision. zzag added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. zzag requested review of this revision. REVISION SUMMARY The EWMH spec doesn't have the _NET_WM_WINDOW_TYPE_COMBOBOX atom. Instead, it has