This revision was not accepted when it landed; it landed in state "Needs
Revision".
This revision was automatically updated to reflect the committed changes.
Closed by commit R320:ec93501d3318: [AppImage Thumbnailer] Avoid creating
QTemporaryFile (authored by broulik).
Herald added projects:
TheAssassin added a comment.
The AppImage project doesn't do any versioning right now. We've recently
extracted libappimage into a separate project to be able to start versioning of
it, as projects like KDE expect and somehow need that. We're discussing a
suitable versioning scheme right
anthonyfieroni added a comment.
Maybe it's better to make new code conditional to version that satisfy
appimage_read_file_into_buffer_following_symlinks
REPOSITORY
R320 KIO Extras
REVISION DETAIL
https://phabricator.kde.org/D15417
To: broulik, #frameworks, TheAssassin, anthonyfieroni
anthonyfieroni requested changes to this revision.
This revision now requires changes to proceed.
REPOSITORY
R320 KIO Extras
REVISION DETAIL
https://phabricator.kde.org/D15417
To: broulik, #frameworks, TheAssassin, anthonyfieroni
anthonyfieroni added a comment.
https://phabricator.kde.org/source/kio-extras/browse/master/thumbnail/CMakeLists.txt$10
It should be specified the version that contains
appimage_read_file_into_buffer_following_symlinks
REPOSITORY
R320 KIO Extras
REVISION DETAIL
TheAssassin accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R320 KIO Extras
REVISION DETAIL
https://phabricator.kde.org/D15417
To: broulik, #frameworks, TheAssassin, anthonyfieroni
broulik created this revision.
broulik added reviewers: Frameworks, TheAssassin, anthonyfieroni.
broulik requested review of this revision.
REVISION SUMMARY
Instead use new API that returns a buffer to avoid writing to the file system
TEST PLAN
Built libappimage with
