D15443: [server] Allow multiple touch interfaces per client and remove fallback code

2018-09-13 Thread Roman Gilg
romangg updated this revision to Diff 41513. romangg added a comment. Readd fall back code REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15443?vs=41445=41513 BRANCH refactorSeatTouch REVISION DETAIL https://phabricator.kde.org/D15443 AFFECTED

D15443: [server] Allow multiple touch interfaces per client and remove fallback code

2018-09-12 Thread Roman Gilg
romangg added a comment. In D15443#324889 , @davidedmundson wrote: > I don't understand removing this. If I have an app that doesn't understand touch doesn't it make sense to synthesise a pointer? I didn't read the code correctly.

D15443: [server] Allow multiple touch interfaces per client and remove fallback code

2018-09-12 Thread David Edmundson
davidedmundson added a comment. Oh, I see what you're saying, I misread, sorry. That does indeed make sense. > Some undocumented fallback code has been removed as well. Platforms not supporting touch are just considered not capable instead. I don't understand removing this. If I

D15443: [server] Allow multiple touch interfaces per client and remove fallback code

2018-09-12 Thread Roman Gilg
romangg added a comment. I believe it works like this: A seat has one global pointer, one global keyboard and one global touch "object" each. But clients can bind to them multiple times. That's why there are focus.pointers and focus.keyboards vectors although there is only one global

D15443: [server] Allow multiple touch interfaces per client and remove fallback code

2018-09-12 Thread David Edmundson
davidedmundson added a comment. > has been for no apparent reason From the spec (emphasis mine) The wl_touch interface represents **a** touchscreen associated with a seat. The wl_pointer interface represents **one or more** input devices, The wl_keyboard interface

D15443: [server] Allow multiple touch interfaces per client and remove fallback code

2018-09-12 Thread Roman Gilg
romangg added a dependent revision: D15464: [server] Touch drag support. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D15443 To: romangg, #kwin, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15443: [server] Allow multiple touch interfaces per client and remove fallback code

2018-09-11 Thread Roman Gilg
romangg created this revision. romangg added reviewers: KWin, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. romangg requested review of this revision. REVISION SUMMARY The touch related code in the seat interface class has been for no apparent