D15557: Improve "insufficient disk space" error messgae

2018-09-17 Thread Shubham
shubham added a comment. Maybe "Dont have enough space available on the disk" REPOSITORY R241 KIO BRANCH improve-insufficient-disk-space-error-message (branched from master) REVISION DETAIL https://phabricator.kde.org/D15557 To: ngraham, #frameworks, #vdg, #dolphin, shubham Cc:

D15557: Improve "insufficient disk space" error messgae

2018-09-17 Thread Kai Uwe Broulik
broulik added a comment. +1 REPOSITORY R241 KIO BRANCH improve-insufficient-disk-space-error-message (branched from master) REVISION DETAIL https://phabricator.kde.org/D15557 To: ngraham, #frameworks, #vdg, #dolphin, shubham Cc: broulik, abetts, kde-frameworks-devel, michaelh,

D15557: Improve "insufficient disk space" error messgae

2018-09-17 Thread Andres Betts
abetts added a comment. In D15557#327094 , @ngraham wrote: > We can't use the words "file" or "move" since this part of the code can't know whether the user is moving or copying, or whether the thing being moved or copied is a file or a

D15557: Improve "insufficient disk space" error messgae

2018-09-16 Thread Nathaniel Graham
ngraham added a comment. We can't use the words "file" or "move" since this part of the code can't know whether the user is moving or copying, or whether the thing being moved or copied is a file or a directory. Adjusting the code here to know those pieces of information not easily possible

D15557: Improve "insufficient disk space" error messgae

2018-09-16 Thread Andres Betts
abetts added a comment. I like the proposal already. I would just add other strings for perspective: - Cannot move file. File larger than remaining space. - Unable to move file, insufficient space remaining. REPOSITORY R241 KIO BRANCH improve-insufficient-disk-space-error-message

D15557: Improve "insufficient disk space" error messgae

2018-09-16 Thread Shubham
shubham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH improve-insufficient-disk-space-error-message (branched from master) REVISION DETAIL https://phabricator.kde.org/D15557 To: ngraham, #frameworks, #vdg, #dolphin, shubham Cc:

D15557: Improve "insufficient disk space" error messgae

2018-09-16 Thread Nathaniel Graham
ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15557 To: ngraham, #frameworks, #vdg, #dolphin, shubham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15557: Improve "insufficient disk space" error messgae

2018-09-16 Thread Nathaniel Graham
ngraham created this revision. ngraham added reviewers: Frameworks, VDG, Dolphin, shubham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY The prior error was misleading, and always said "Disk