D15558: Remove misleading use of KDE_INSTALL_PYTHONBINDINGSDIR

2018-09-27 Thread Stefan Brüns
This revision was automatically updated to reflect the committed changes. Closed by commit R244:288d6d3a9d18: Remove misleading use of KDE_INSTALL_PYTHONBINDINGSDIR (authored by bruns). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15558?vs=41771=42453

D15558: Remove misleading use of KDE_INSTALL_PYTHONBINDINGSDIR

2018-09-27 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D15558 To: bruns, #frameworks, apol Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D15558: Remove misleading use of KDE_INSTALL_PYTHONBINDINGSDIR

2018-09-27 Thread Stefan Brüns
bruns added a comment. In D15558#333027 , @apol wrote: > So the problem is that nobody is defining KDE_INSTALL_PYTHONBINDINGSDIR right? > Makes sense to me to remove this line then, if the default behaviour works for us (it seems so).

D15558: Remove misleading use of KDE_INSTALL_PYTHONBINDINGSDIR

2018-09-27 Thread Aleix Pol Gonzalez
apol added a comment. So the problem is that nobody is defining KDE_INSTALL_PYTHONBINDINGSDIR right? Makes sense to me to remove this line then, if the default behaviour works for us (it seems so). REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D15558 To:

D15558: Remove misleading use of KDE_INSTALL_PYTHONBINDINGSDIR

2018-09-27 Thread Stefan Brüns
bruns added a comment. Ping! REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D15558 To: bruns, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15558: Remove misleading use of KDE_INSTALL_PYTHONBINDINGSDIR

2018-09-16 Thread Stefan Brüns
bruns added a comment. These are the other places which should be treated the same: https://lxr.kde.org/search?_filestring=&_string=KDE_INSTALL_PYTHONBINDINGSDIR REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D15558 To: bruns, #frameworks Cc:

D15558: Remove misleading use of KDE_INSTALL_PYTHONBINDINGSDIR

2018-09-16 Thread Stefan Brüns
bruns created this revision. bruns added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Although KDE_INSTALL_PYTHONBINDINGSDIR follows the the standard pattern of