D15611: [KCollapsibleGroupBox] Respect style's widget animation duration

2018-09-26 Thread Christoph Feck
This revision was automatically updated to reflect the committed changes. Closed by commit R236:953939b4727c: [KCollapsibleGroupBox] Respect style's widget animation duration (authored by cfeck). REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15611?vs=4

D15611: [KCollapsibleGroupBox] Respect style's widget animation duration

2018-09-23 Thread Elvis Angelaccio
elvisangelaccio accepted this revision. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D15611 To: cfeck, #frameworks, ngraham, elvisangelaccio Cc: broulik, ngraham, kde-frameworks-devel, michaelh, bruns

D15611: [KCollapsibleGroupBox] Respect style's widget animation duration

2018-09-20 Thread Nathaniel Graham
ngraham added a comment. That would only affect the speed of appearing and disappearing though, right? Not the total duration that is status on the screen. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D15611 To: cfeck, #frameworks, ngraham Cc: broulik, ngra

D15611: [KCollapsibleGroupBox] Respect style's widget animation duration

2018-09-20 Thread Christoph Feck
cfeck added a comment. In D15611#328845 , @ngraham wrote: > In D15611#328821 , @cfeck wrote: > > > Would KMessageWidget need the same change? > > > Yeah, I think so. No sense in having a user-tw

D15611: [KCollapsibleGroupBox] Respect style's widget animation duration

2018-09-20 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. In D15611#328821 , @cfeck wrote: > Indeed Breeze style was already updated to return the actual configured duration on Qt 5.10. > > Woul

D15611: [KCollapsibleGroupBox] Respect style's widget animation duration

2018-09-20 Thread Christoph Feck
cfeck added a comment. Indeed Breeze style was already updated to return the actual configured duration on Qt 5.10. Would KMessageWidget need the same change? REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D15611 To: cfeck, #frameworks Cc: broulik, ngrah

D15611: [KCollapsibleGroupBox] Respect style's widget animation duration

2018-09-20 Thread Christoph Feck
cfeck updated this revision to Diff 41978. cfeck retitled this revision from "[KCollapsibleGroupBox] Respect styles that disable widget animations" to "[KCollapsibleGroupBox] Respect style's widget animation duration". cfeck edited the summary of this revision. cfeck edited the test plan for this