D16137: Add an option to KConfigDialog to fit page contents horizontally

kadabash added a comment. While adapting the settings window in Cantor to this proposed change I have discovered that it influences the `sizeHint()` of other (non-modified) pages in the same window. This leads to a worse layout than before. As I cannot currently find the source of that

D16137: Add an option to KConfigDialog to fit page contents horizontally

ngraham added a comment. In D16137#346032 , @kadabash wrote: > Vertical fitting only occurs on displays that Qt deems large enough. > Displays that are just high enough to fit the content vertically > are apparently sometimes not

D16137: Add an option to KConfigDialog to fit page contents horizontally

kadabash updated this revision to Diff 43944. kadabash added a comment. Fit page content horizontally *and* vertically Vertical fitting only occurs on displays that Qt deems large enough. Displays that are just high enough to fit the content vertically are apparently sometimes not

D16137: Add an option to KConfigDialog to fit page contents horizontally

aacid added a comment. Yep, this looks more like it :) You're missing @since markers (in the documentation of the new functions) for the KF5 version this will be introduced, but i'd say let's wait for someone to give the final approval and then you remember to commit the correct version

D16137: Add an option to KConfigDialog to fit page contents horizontally

svuorela added a comment. > Did you imagine something like what I changed in D16137#343060 (the latest change) ? I think Albert imagined something like that. It is at least what I imagined when I read his comments. I think I also like it

D16137: Add an option to KConfigDialog to fit page contents horizontally

kadabash added a comment. In D16137#342973 , @aacid wrote: > That's almost good, but the flag name should be more general, think like for example you would remove the manage bool and convert it to a flag too, so that if it the future someone

D16137: Add an option to KConfigDialog to fit page contents horizontally

kadabash updated this revision to Diff 43607. kadabash added a comment. Generalize page flags to options not related to alignment REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16137?vs=43499=43607 BRANCH config-dialog-content-fit (branched from

D16137: Add an option to KConfigDialog to fit page contents horizontally

aacid added a comment. That's almost good, but the flag name should be more general, think like for example you would remove the manage bool and convert it to a flag too, so that if it the future someone needs to add a new flag, they can add it to that enum and don't need a new parameter.

D16137: Add an option to KConfigDialog to fit page contents horizontally

ngraham added a comment. +1, nice to see this. Once it lands, feel free to start porting apps to use it--for the ones where it'll be acceptable to depend on Frameworks 5.52 as a minimum version. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D16137 To:

D16137: Add an option to KConfigDialog to fit page contents horizontally

svuorela added a comment. from a source & binary compatibility point of view, this looks great. I guess we should maybe plan deprecating (and at kf6 time remove) the old ones ? (But this is not an objection to the current change) I'm not a KConfigWidgets maintainer, so I will not

D16137: Add an option to KConfigDialog to fit page contents horizontally

kadabash added a comment. Sorry for the duplicate updates, I messed up my Arcanist commands. Thanks for your help so far, I tried to follow your suggestions in the above change. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D16137 To: kadabash Cc:

D16137: Add an option to KConfigDialog to fit page contents horizontally

kadabash updated this revision to Diff 43499. kadabash added a comment. Restore binary compatibility and introduce alignment flags REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16137?vs=43498=43499 BRANCH config-dialog-content-fit (branched from

D16137: Add an option to KConfigDialog to fit page contents horizontally

kadabash updated this revision to Diff 43498. kadabash added a comment. Restore binary compatibility and introduce alignment flags REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16137?vs=43413=43498 BRANCH config-dialog-content-fit (branched from

D16137: Add an option to KConfigDialog to fit page contents horizontally

aacid added a comment. In D16137#341984 , @kadabash wrote: > I have to admit, I don't know how to implement a version with flags correctly. Look at kcmodule.h for example you'll see some flags defined there, then there's a setButtons

D16137: Add an option to KConfigDialog to fit page contents horizontally

kadabash added a comment. I have to admit, I don't know how to implement a version with flags correctly. Did I understand you correctly in that an overload with signature addPage(QWidget *page, const QString , const QString = QString(), const QString = QString(), bool manage =

D16137: Add an option to KConfigDialog to fit page contents horizontally

aacid added a comment. Adding new parameters is unfortunately Binary Incompatible so this can't go in this way, for it to work you'd need to add a new function with all the parameters and then call one from the other. Maybe what we need is one that takes two bools we should have one

D16137: Add an option to KConfigDialog to fit page contents horizontally

kadabash created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kadabash requested review of this revision. REVISION SUMMARY Scrolling a settings page horizontally feels awkward most of the time. This (optionally) lets the dialogue resize