D16189: kio_help: Fix crash in QCoreApplication when accessing help://

2018-11-06 Thread Harald Sitter
sitter added a comment. https://mail.kde.org/pipermail/distributions/2018-October/000298.html REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16189 To: mpyne, #frameworks, sitter, dfaure, broulik Cc: sredman, albertvaka, broulik, dfaure, kde-frameworks-devel, michaelh,

D16189: kio_help: Fix crash in QCoreApplication when accessing help://

2018-11-06 Thread Albert Vaca Cintora
albertvaka added a comment. Old apps that didn't have a QApplication are broken by this version of KIO. Definitely a regression to me :/ REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16189 To: mpyne, #frameworks, sitter, dfaure, broulik Cc: sredman, albertvaka,

D16189: kio_help: Fix crash in QCoreApplication when accessing help://

2018-11-06 Thread Harald Sitter
sitter added a comment. It was fixed in that it doesn't crash anymore. Due to crash handling now going through kcrash you still want to have a coreapp in every slave though. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16189 To: mpyne, #frameworks, sitter, dfaure,

D16189: kio_help: Fix crash in QCoreApplication when accessing help://

2018-11-05 Thread Albert Vaca Cintora
albertvaka added a comment. As I commented in this similar patch (https://phabricator.kde.org/D16692 ) I think this is a regression that should be fixed in KIO. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16189 To: mpyne, #frameworks, sitter, dfaure, broulik Cc:

D16189: kio_help: Fix crash in QCoreApplication when accessing help://

2018-10-14 Thread Michael Pyne
This revision was automatically updated to reflect the committed changes. Closed by commit R241:cf3b0d102855: kio_help: Fix crash in QCoreApplication when accessing help://. (authored by mpyne). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16189?vs=43569=43593

D16189: kio_help: Fix crash in QCoreApplication when accessing help://

2018-10-14 Thread Kai Uwe Broulik
broulik accepted this revision. broulik added a comment. Funny, I just noticed the same thing yesterday and was just about to make a patch but then saw this REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16189 To: mpyne, #frameworks, sitter, dfaure, broulik Cc:

D16189: kio_help: Fix crash in QCoreApplication when accessing help://

2018-10-14 Thread David Faure
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. See also https://phabricator.kde.org/D16183 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16189 To: mpyne, #frameworks, sitter, dfaure Cc: dfaure,

D16189: kio_help: Fix crash in QCoreApplication when accessing help://

2018-10-13 Thread Nathaniel Graham
ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16189 To: mpyne, #frameworks, sitter Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16189: kio_help: Fix crash in QCoreApplication when accessing help://

2018-10-13 Thread Michael Pyne
mpyne created this revision. mpyne added reviewers: Frameworks, sitter. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mpyne requested review of this revision. REVISION SUMMARY A recent commit d428fc8e6447ede81f1e1911d0b66b39265672f3